Date: Mon, 5 Feb 2001 15:06:30 +0100 (CET) From: Andre Albsmeier <andre.albsmeier@mchp.siemens.de> To: FreeBSD-gnats-submit@freebsd.org Subject: kern/24868: PATCH to fix kernel build if path to sources contain a dash Message-ID: <200102051406.f15E6UU02816@curry.mchp.siemens.de>
next in thread | raw e-mail | index | archive | help
>Number: 24868
>Category: kern
>Synopsis: PATCH to fix kernel build if path to sources contain a dash
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Feb 05 06:10:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator: Andre Albsmeier
>Release: FreeBSD 4.2-STABLE i386
>Organization:
>Environment:
4.2-STABLE since the import of Cameron's new sound code.
>Description:
When building a kernel the /sys/kern/makeops.pl script is called to
build .c and .h files from .m files. This fails if the path to
the source tree contains a dash (-).
The makeops.pl fails since it thinks that all input files are options
because the regex matches the dash:
andre@bali:/tmp/bla>perl5 /src/src-4/sys/kern/makeops.pl -h /src/src-4/sys/kern/device_if.m
andre@bali:/tmp/bla>ls -l
andre@bali:/tmp/bla>
>How-To-Repeat:
Put your sources into /src/src-4 and make /usr/src a symlink to it.
Build a kernel.
>Fix:
IMHO it is sufficient to change the regex to match only dashes
that are at the beginning of the argument:
--- sys/kern/makeops.pl.ORI Mon Feb 5 14:55:51 2001
+++ sys/kern/makeops.pl Mon Feb 5 14:55:59 2001
@@ -36,7 +36,7 @@
# Process the command line
#
while ( $arg = shift @ARGV ) {
- if ( $arg =~ m/-.*/ ) {
+ if ( $arg =~ m/^-.*/ ) {
push @args, $arg;
} elsif ( $arg =~ m/\.m$/ ) {
push @filenames, $arg;
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200102051406.f15E6UU02816>