From owner-freebsd-amd64@FreeBSD.ORG Mon Feb 16 01:43:20 2009 Return-Path: Delivered-To: freebsd-amd64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5511F106566B for ; Mon, 16 Feb 2009 01:43:20 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.179]) by mx1.freebsd.org (Postfix) with ESMTP id 280AD8FC0A for ; Mon, 16 Feb 2009 01:43:20 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: by wa-out-1112.google.com with SMTP id k34so1005829wah.27 for ; Sun, 15 Feb 2009 17:43:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=EjvY5wf8FHSKma3mnXORDNjdSbCbn48OXzDBGv2Zk8g=; b=YaDmOpecjc1QLTkThyNDNPa9O+1276ATEbF7jKKCa3n7M9HnCNAZTrvd1eG32fUGqb 4pQZP+zvAgsCBYWz++WeoD8KnvCLCMyiHJsG7r8aAQ8pctimr42+8ZjBWSuOtOG9fuea eqGBQoOVA9F8nzAWaf4IJHfB0s+DALkjvmdGI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=XoBEWxK8mBPWVIB6RpiRLZ940i0y2URnl7Rnm2fC54gb2tqKaVZ21kCVRTrZwT2DlL gwlprBbsahOWet2mJt+M1jlZ4tJoMCeJVNDKt7oVU6UQs91cvzbP/w8WgUQoXsVdEVM5 2xg0Bls0dRbbX1fnU+AsR1dBOC5XsvaTJDti8= MIME-Version: 1.0 Received: by 10.114.73.14 with SMTP id v14mr1890323waa.104.1234747347119; Sun, 15 Feb 2009 17:22:27 -0800 (PST) In-Reply-To: <442505824.71673.1234559053919.JavaMail.apache@mail53.abv.bg> References: <442505824.71673.1234559053919.JavaMail.apache@mail53.abv.bg> Date: Sun, 15 Feb 2009 17:22:27 -0800 Message-ID: <7d6fde3d0902151722x24aeed88na79ed5093f5d2569@mail.gmail.com> From: Garrett Cooper To: Mario Pavlov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: dev@lists.pcbsd.org, kris@pcbsd.com, freebsd-current@freebsd.org, freebsd-amd64@freebsd.org Subject: Re: [Fw: Re: [PC-BSD Dev] vmap()-like kernel interface ] X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2009 01:43:20 -0000 On Fri, Feb 13, 2009 at 1:04 PM, Mario Pavlov wrote: > Hi, > please find the attached e-mail > > regards > mgp > > P.S. thanks, PC-BSD team I'm not a kernel dev, but I noted that pmap_unmapcontig doesn't take into consideration when va is NULL; I know it's bad driver programming if uncontig is implicitly called with NULL, but there should be some error handling or something here (a NULL deref will occur in pmap_qremove, which will cause a panic). Thanks, -Garrett