From owner-cvs-src@FreeBSD.ORG Wed Jul 2 07:32:48 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 146AB37B401; Wed, 2 Jul 2003 07:32:48 -0700 (PDT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8735343FB1; Wed, 2 Jul 2003 07:32:47 -0700 (PDT) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id 6F16D2ED437; Wed, 2 Jul 2003 07:32:47 -0700 (PDT) Date: Wed, 2 Jul 2003 16:32:47 +0200 From: Maxime Henrion To: Harti Brandt Message-ID: <20030702143247.GK42121@elvis.mu.org> References: <200307021353.h62Drfvp083130@repoman.freebsd.org> <20030702140500.GJ42121@elvis.mu.org> <20030702162128.S30117@beagle.fokus.fraunhofer.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030702162128.S30117@beagle.fokus.fraunhofer.de> User-Agent: Mutt/1.4.1i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/fatm if_fatm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jul 2003 14:32:48 -0000 Harti Brandt wrote: > On Wed, 2 Jul 2003, Maxime Henrion wrote: > > MH>Hartmut Brandt wrote: > MH>> harti 2003/07/02 06:53:41 PDT > MH>> > MH>> FreeBSD src repository > MH>> > MH>> Modified files: > MH>> sys/dev/fatm if_fatm.c > MH>> Log: > MH>> Make the bus_dma_tag_create use NULL for the lock arguments. We are > MH>> careful to call all map_load calls with BUS_DMA_NOWAIT because we > MH>> really don't want some PDUs to wait while others go out - ATM guarantees > MH>> the ordering of cells and also of PDUs (within one VC, that is). With > MH>> BUS_DMA_NOWAIT bus_dmamap_load should never return EINPROGRESS. > MH> > MH>FWIW, this is true since yesterday only, because I updated all the other > MH>busdma backends which use bounce pages to behave this way. Previously, > MH>this was only true for x86 and amd64. > > When locking through all the bus_dma implementations I always wonder > whether it is possible to factor out the common code (except for sparc64). > They all lock the same, just with different small bugs... Yes, I'm going to factor out as much code as I can from the busdma API, and this is why I sync'd all the backends with each other. Cheers, Maxime