From owner-cvs-all@FreeBSD.ORG Mon Apr 30 14:29:43 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ACA7C16A402; Mon, 30 Apr 2007 14:29:43 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 6B94B13C44B; Mon, 30 Apr 2007 14:29:43 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l3UEQXhH095448; Mon, 30 Apr 2007 08:26:33 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 30 Apr 2007 08:26:45 -0600 (MDT) Message-Id: <20070430.082645.270753761.imp@bsdimp.com> To: ache@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200704301144.l3UBig50070087@repoman.freebsd.org> References: <200704301144.l3UBig50070087@repoman.freebsd.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 30 Apr 2007 08:26:34 -0600 (MDT) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/sh var.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 14:29:43 -0000 In message: <200704301144.l3UBig50070087@repoman.freebsd.org> "Andrey A. Chernov" writes: : ache 2007-04-30 11:44:42 UTC : : FreeBSD src repository : : Modified files: : bin/sh var.c : Log: : Put some safeguards: : 1) Under POSIX unsetenv("foo=bar") is explicit error and not equal : to unsetenv("foo") : 2) Prepare for upcomig POSIXed putenv() rewrite: make putenv() calls : portable and conforming to standard. Andrey, Can you bump the __FreeBSD_version in sys/param.h for these changes and document it in the FreeBSD committer's handbook? Warner