From owner-cvs-all  Mon Apr 22 16:13: 9 2002
Delivered-To: cvs-all@freebsd.org
Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169])
	by hub.freebsd.org (Postfix) with ESMTP
	id CFCAD37B633; Mon, 22 Apr 2002 16:04:55 -0700 (PDT)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g3MN4qYm090489;
	Mon, 22 Apr 2002 16:04:52 -0700 (PDT)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g3MN3b9s090473;
	Mon, 22 Apr 2002 16:03:37 -0700 (PDT)
Date: Mon, 22 Apr 2002 16:03:36 -0700
From: "David O'Brien" <obrien@FreeBSD.ORG>
To: Mike Barcroft <mike@FreeBSD.ORG>
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.bin/ldd ldd.c sods.c
Message-ID: <20020422160336.A90450@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.ORG
References: <200204202009.g3KK9Uh55665@freefall.freebsd.org> <20020422111856.B49799@dragon.nuxi.com> <20020422180652.A72727@espresso.q9media.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20020422180652.A72727@espresso.q9media.com>; from mike@FreeBSD.ORG on Mon, Apr 22, 2002 at 06:06:52PM -0400
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, Apr 22, 2002 at 06:06:52PM -0400, Mike Barcroft wrote:
> > >   Modified files:
> > >     usr.bin/ldd          ldd.c sods.c 
> > >   Log:
> > >   Include <arpa/inet.h> for prototype of ntohl() used in the N_BADMAG()
> > >   macro.
> > 
> > This seems very silly -- 'ldd' has zero to do with networking.  Perhaps
> > ntohl really needs to be moved to another header, which apra/inet.h
> > includes.
> 
> Then why is it using Network to host conversion macros?  The Standard
> defines these macros in <arpa/inet.h> and <netinet/in.h>.  We used to

It is used in /usr/include/sys/imgact_aout.h:#define  N_BADMAG(ex) \
which is because we had no other endian conversion bits at the time.
This could be changed to what ever bits you and tmm crafted.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message