From owner-cvs-src@FreeBSD.ORG Thu Dec 22 05:05:04 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6520216A41F; Thu, 22 Dec 2005 05:05:04 +0000 (GMT) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A6B2C43D4C; Thu, 22 Dec 2005 05:05:00 +0000 (GMT) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jBM550xK078231; Thu, 22 Dec 2005 05:05:00 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jBM550VI078230; Thu, 22 Dec 2005 05:05:00 GMT (envelope-from emaste) Message-Id: <200512220505.jBM550VI078230@repoman.freebsd.org> From: Ed Maste Date: Thu, 22 Dec 2005 05:05:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/net if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2005 05:05:04 -0000 emaste 2005-12-22 05:05:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/net if.c Log: MFC r1.235, r1.237, r1.238: (1.235) - Introduce a helper function if_setflag() containing the code common to ifpromisc() and if_allmulti() instead of duplicating the code poorly, with different bugs. - Call ifp->if_ioctl() in a consistent way: always use more compatible C syntax and check whether ifp->if_ioctl is not NULL prior to the call. (1.237) Rename equal() macro to sa_equal(), which matches the definitions of sa_equal() in other files, and makes it more clear what equal() is comparing. (1.238) In multicast routines: Compare pointers with NULL rather than treating them as booleans. Compare pointers with NULL rather than 0 to make it more clear they are pointers. Assign pointers value of NULL rather than 0 to make it more clear they are pointers. Approved by: scottl Silence from: rwatson (mentor) Revision Changes Path 1.199.2.19 +127 -100 src/sys/net/if.c