From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jul 14 15:50:06 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3EA01065689 for ; Mon, 14 Jul 2008 15:50:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 88CD38FC1A for ; Mon, 14 Jul 2008 15:50:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m6EFo6bQ043639 for ; Mon, 14 Jul 2008 15:50:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m6EFo62u043638; Mon, 14 Jul 2008 15:50:06 GMT (envelope-from gnats) Resent-Date: Mon, 14 Jul 2008 15:50:06 GMT Resent-Message-Id: <200807141550.m6EFo62u043638@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Yuri Pankov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C4C31065673 for ; Mon, 14 Jul 2008 15:46:27 +0000 (UTC) (envelope-from yuri.pankov@gmail.com) Received: from fk-out-0910.google.com (fk-out-0910.google.com [209.85.128.187]) by mx1.freebsd.org (Postfix) with ESMTP id B0FE68FC08 for ; Mon, 14 Jul 2008 15:46:26 +0000 (UTC) (envelope-from yuri.pankov@gmail.com) Received: by fk-out-0910.google.com with SMTP id k31so2942321fkk.11 for ; Mon, 14 Jul 2008 08:46:25 -0700 (PDT) Received: by 10.187.190.12 with SMTP id s12mr1777888fap.21.1216048644663; Mon, 14 Jul 2008 08:17:24 -0700 (PDT) Received: from darklight.homeunix.org ( [85.173.19.107]) by mx.google.com with ESMTPS id 18sm4266637hue.17.2008.07.14.08.17.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 14 Jul 2008 08:17:23 -0700 (PDT) Received: from darklight.homeunix.org (yuri@darklight.homeunix.org [127.0.0.1]) by darklight.homeunix.org (8.14.2/8.14.2) with ESMTP id m6EFHJs1000643 for ; Mon, 14 Jul 2008 19:17:19 +0400 (MSD) (envelope-from yuri.pankov@gmail.com) Received: (from yuri@localhost) by darklight.homeunix.org (8.14.2/8.14.2/Submit) id m6EFHJcv000642; Mon, 14 Jul 2008 19:17:19 +0400 (MSD) (envelope-from yuri.pankov@gmail.com) Message-Id: <200807141517.m6EFHJcv000642@darklight.homeunix.org> Date: Mon, 14 Jul 2008 19:17:19 +0400 (MSD) From: Yuri Pankov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/125605: [PATCH] bsd.ports.mk: add -DLDAP_DEPRECATED to CFLAGS; remove support for OpenLDAP 2.2 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Yuri Pankov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2008 15:50:06 -0000 >Number: 125605 >Category: ports >Synopsis: [PATCH] bsd.ports.mk: add -DLDAP_DEPRECATED to CFLAGS; remove support for OpenLDAP 2.2 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jul 14 15:50:06 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Yuri Pankov >Release: FreeBSD 8.0-CURRENT amd64 >Organization: >Environment: System: FreeBSD darklight.homeunix.org 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sun Jul 13 20:51:44 MSD 2008 yuri@darklight.homeunix.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Some (many?) ports are still using functions which are deprecated in OpenLDAP 2.3, 2.4. Those functions are #ifdef'ed LDAP_DEPRECATED in ldap.h, which leads to segfaults on at least FreeBSD/amd64 due to missing function prototypes. Adding -DLDAP_DEPRECATED to CFLAGS if using openldap2?-client could solve the problem. >How-To-Repeat: Install a port using deprecated functions on FreeBSD/amd64 (namely cyrus-sasl2-saslauthd). >Fix: Add -DLDAP_DEPRECATED to CFLAGS when USE_OPENLDAP is defined. While here, remove support for long dead openldap22-client port. --- bsd.ports.mk.diff begins here --- Index: ports/Mk/bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.595 diff -u -r1.595 bsd.port.mk --- ports/Mk/bsd.port.mk 30 Jun 2008 20:16:17 -0000 1.595 +++ ports/Mk/bsd.port.mk 14 Jul 2008 15:01:51 -0000 @@ -1696,14 +1696,13 @@ .endif .if defined(USE_OPENLDAP) +CFLAGS+= -DLDAP_DEPRECATED .if defined(WANT_OPENLDAP_SASL) _OPENLDAP_FLAVOUR= -sasl .else _OPENLDAP_FLAVOUR= .endif -.if ${WANT_OPENLDAP_VER} == 22 -LIB_DEPENDS+= ldap-2.2.7:${PORTSDIR}/net/openldap22${_OPENLDAP_FLAVOUR}-client -.elif ${WANT_OPENLDAP_VER} == 23 +.if ${WANT_OPENLDAP_VER} == 23 LIB_DEPENDS+= ldap-2.3.2:${PORTSDIR}/net/openldap23${_OPENLDAP_FLAVOUR}-client .elif ${WANT_OPENLDAP_VER} == 24 LIB_DEPENDS+= ldap-2.4.2:${PORTSDIR}/net/openldap24${_OPENLDAP_FLAVOUR}-client --- bsd.ports.mk.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: