From owner-freebsd-java@FreeBSD.ORG  Mon Mar 19 23:46:04 2012
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: freebsd-java@FreeBSD.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 2B6B31065674;
	Mon, 19 Mar 2012 23:46:03 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Jason Helfman <jgh@FreeBSD.org>
Date: Mon, 19 Mar 2012 19:45:45 -0400
User-Agent: KMail/1.6.2
References: <20120318180225.GA51618@dormouse.experts-exchange.com>
	<201203191900.42677.jkim@FreeBSD.org>
	<20120319230818.GJ46825@dormouse.experts-exchange.com>
In-Reply-To: <20120319230818.GJ46825@dormouse.experts-exchange.com>
MIME-Version: 1.0
Content-Disposition: inline
Message-Id: <201203191945.50219.jkim@FreeBSD.org>
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: freebsd-eclipse@FreeBSD.org, freebsd-java@FreeBSD.org
Subject: Re: [RFC] New Port: Eclipse Java Compiler, java/eclipse-ecj
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2012 23:46:04 -0000

On Monday 19 March 2012 07:08 pm, Jason Helfman wrote:
> On Mon, Mar 19, 2012 at 07:00:39PM -0400, Jung-uk Kim thus spake:
> >Hmm...  It doesn't seem right.
> >
> >% cat /usr/local/bin/ecj.sh
> >#!/bin/sh
> >
> >/usr/local/openjdk6/bin/javac -classpath
> > /usr/local/share/java/classes/ecj.jar $1 % /usr/local/bin/ecj.sh
> > -version
> >javac 1.6.0_30
> >% /usr/local/openjdk6/bin/javac -version
> >javac 1.6.0_30
> >
> >Please note it isn't coming from ecj.jar.
>
> That is grabbing the version of javac based on the shell script.

Yes, that's exactly my point. :-)

> I'm not certain if you can get a vesion of the jar with an
> argument, or if that argument is even valid.

Of course, it is valid:

% fetch 
http://download.eclipse.org/eclipse/downloads/drops/R-3.7.2-201202080800/ecj-3.7.2.jar
ecj-3.7.2.jar                                 100% of 1708 kB 1851 
kBps
% /usr/local/openjdk6/bin/java -jar ecj-3.7.2.jar -version
Eclipse Compiler for Java(TM) 0.B83_R37x, 3.7.2, Copyright IBM Corp 
2000, 2011. All rights reserved.

> >Also, `$1' should be `$*'.
>
> I can change this.

Thanks.

While you are at it, please add these:

USE_ZIP=        yes
NO_WRKSUBDIR=   yes

and remove these:

BUILD_WRKSRC=   ${WRKDIR}
...
EXTRACT_CMD=	${TAR}
EXTRACT_BEFORE_ARGS=    xf
EXTRACT_AFTER_ARGS=     -C ${WRKDIR}

Jung-uk Kim