From owner-freebsd-stable Thu Oct 10 3:20:50 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 58C0C37B401 for ; Thu, 10 Oct 2002 03:20:49 -0700 (PDT) Received: from cs.rpi.edu (mumble.cs.rpi.edu [128.213.8.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A90F43EAA for ; Thu, 10 Oct 2002 03:20:47 -0700 (PDT) (envelope-from crossd@cs.rpi.edu) Received: from monica.cs.rpi.edu (monica.cs.rpi.edu [128.213.7.3]) by cs.rpi.edu (8.9.3/8.9.3) with ESMTP id GAA49370; Thu, 10 Oct 2002 06:20:45 -0400 (EDT) Received: from monica.cs.rpi.edu (crossd@localhost) by monica.cs.rpi.edu (8.11.6/8.11.6) with ESMTP id g9AAKjX10490; Thu, 10 Oct 2002 06:20:45 -0400 (EDT) (envelope-from crossd@monica.cs.rpi.edu) Message-Id: <200210101020.g9AAKjX10490@monica.cs.rpi.edu> To: "Daniel O'Connor" Cc: "David E. Cross" , freebsd-stable@FreeBSD.ORG, crossd@cs.rpi.edu Subject: Re: make release question In-Reply-To: Message from "Daniel O'Connor" of "10 Oct 2002 19:09:38 +0930." <1034242786.80568.98.camel@chowder.gsoft.com.au> References: <200210100936.g9A9abI21528@pegasus.cs.rpi.edu> <1034242786.80568.98.camel@chowder.gsoft.com.au> Date: Thu, 10 Oct 2002 06:20:45 -0400 From: "David E. Cross" Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Yeah, I just stumbled across the magic answer myself. ${buildroot}/modules is *empty*. Ok... So I've just been "lucky" before (ie, I use vn(4) enough that I always seem to have it loaded by the time I do a make release). I also dug through the re documentation that says you no longer need vn(4) compiled in because vnconfig(8) would load it for you.. kinda sorta. I'd like to make the following changes: 1) Have make release populate the ${chroot}/modules directory. What's the "best" way to do this. Most likely to copy over /modules from the running system (perhaps look at the sysctl variable to make sure it isn't modules.old or something?) Do we want all of /modules, or just vn.ko? Do we want /kernel (or whatever sysctl tells us? 2) fix vnconfig.c: please see the following code snippet: if (modfind("vn") < 0) if (kldload("vn") < 0 || modfind("vn") < 0) warnx( "cannot find or load \"vn\" kernel module"); Its late/early/whatever, but it seems to me that this could be _very_ easily simplified to: if ((modfind("vn") < 0) && (kldload("vn") < 0)) ... -- David Cross | email: crossd@cs.rpi.edu Lab Director | Rm: 308 Lally Hall Rensselaer Polytechnic Institute, | Ph: 518.276.2860 Department of Computer Science | Fax: 518.276.4033 I speak only for myself. | WinNT:Linux::Linux:FreeBSD To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message