From owner-freebsd-current@FreeBSD.ORG Sat Jan 24 00:35:03 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1163EFF3 for ; Sat, 24 Jan 2015 00:35:03 +0000 (UTC) Received: from mail-pd0-x22d.google.com (mail-pd0-x22d.google.com [IPv6:2607:f8b0:400e:c02::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D3017BD7 for ; Sat, 24 Jan 2015 00:35:02 +0000 (UTC) Received: by mail-pd0-f173.google.com with SMTP id fp1so781191pdb.4 for ; Fri, 23 Jan 2015 16:35:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=r8D1Jpqmk0OghDmHLUWOfzHH0siaWFgwsal09m2LYUY=; b=bd85bjarSPm51vLQ/chHItd8zSaZzxoHYsVz4DbowZdHzYOqON4sMuO+Bb3weL+acC MdU4V32KHSkoTrRPQ28vHJZ0zabY0fKxnZJUdX01qOJS3IJwfgObaM+lz+wPyCUc7+mE ngEu9l7TebPr2qY4ZdYbXBRbBSgtxRSm+EJfSzjWIfo4iNxYWrelL1v1MqyRoAu/EZ1B tuDNcBBdcAj6bN50UlJdBm6s15JfQBNU+tHaGebJzrTw0QUsFKnURmXYlYvJWth/P/8/ Cgshs92mv6DN4eersMfyDP9Nax2rGHUvKicHBJys+sd7xX/yanRWT3sZE1mkFswtnCwt +XhA== X-Received: by 10.66.156.229 with SMTP id wh5mr15423312pab.119.1422059702445; Fri, 23 Jan 2015 16:35:02 -0800 (PST) Received: from [192.168.20.5] (c-98-247-240-204.hsd1.wa.comcast.net. [98.247.240.204]) by mx.google.com with ESMTPSA id l5sm3043467pbq.40.2015.01.23.16.35.01 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 23 Jan 2015 16:35:01 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_29980FBF-9A7A-48F8-AB20-F035AAF70108"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: OptionalObsoleteFiles.inc completeness improvement, try 2 From: Garrett Cooper In-Reply-To: <20150124002956.GI1101@hades.panopticon> Date: Fri, 23 Jan 2015 16:35:00 -0800 Message-Id: <4F0C24D1-9313-49BC-992E-5C31DAC6DADC@gmail.com> References: <20150124002956.GI1101@hades.panopticon> To: Dmitry Marakasov X-Mailer: Apple Mail (2.1878.6) Cc: freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jan 2015 00:35:03 -0000 --Apple-Mail=_29980FBF-9A7A-48F8-AB20-F035AAF70108 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jan 23, 2015, at 16:29, Dmitry Marakasov wrote: > Hi! >=20 > Some years ago I've started a project of improving > OptionalObsoleteFiles.inc completeness, which allows make delete-old > / delete-old-libs / delete-old-dirs targets completelty remove files > which are normally installed when specific src.conf WITHOUT_* knobs > are set. >=20 > In other words, if a user has some WITHOUT_* set in src.conf, > specific files are not installed by installworld, but not removed > by remove-old, which I try to fix. >=20 > In yet other words, I want to make it so `make installworld > -DWITHOUT_foo=3Dyes` and `make installworld && make delete-old > -DWITHOUT_foo=3Dyes` result in the very same file sets. >=20 > Though the project seems to be useful and have real demand (added > to IdeasPage by netchild@, though removed later by brooks@ [1]) > and interest ([2]), the change was ignored back then and now the > patch is completely rotten. I can redo it, but I need a reviewer. > Here's a first small part of the patch: >=20 > https://reviews.freebsd.org/D1600 >=20 > The WIP branch with other changes is [3] >=20 > Also there is a question of delete-old-dirs removing directories > which are created by mtree run by installworld unconditionally. > This seems to be incorrect - either directories should be installed > conditionally or not removed by delete-old-dirs. My patch will > address this issue as well, by not remiving unconditionally installed > dirs. >=20 > [1] = https://wiki.freebsd.org/action/diff/IdeasPage?action=3Ddiff&rev1=3D260&re= v2=3D261 > [2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D168341#c6 > [3] https://github.com/AMDmi3/freebsd/compare/obsolete-files Hi Dmitry, Seems like we=92ve duplicated work a bit. Have you looked at = ^/projects/building-blocks yet ? Thanks! --Apple-Mail=_29980FBF-9A7A-48F8-AB20-F035AAF70108 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUwui0AAoJEMZr5QU6S73eahwIAIKBn5dnwfkueF0nHPdKNzYq aVCfjVrTXobTHmkrz1/PrKanqDRVdOYpBzcDZwVXLyJjIg6+Q38YSnEp0PpRGMff l/IbGsG6iQVyCFan1qK8PCygdGDw7X9vT3RJzMr+wIAFQ1o5Al0mgU8TUuAl5yAR rxUxw/5mkTGw8w1W/ZFTVzliWT6yJQq+CIeXXPR15hSUGcQ61/ivLFM16LL2mMV1 mFBsBjonnZfAKhHIPH68DqvRUm7U4ZfVg7uA3eclQuDJ6ULr42pZJXxwO9BRmMkw V81+dchwpPrOR6RHckCyAi8D8AogWNw+LCh8IAR6n3sEWS7Y+zSU9sRv9LR4FyE= =FRW5 -----END PGP SIGNATURE----- --Apple-Mail=_29980FBF-9A7A-48F8-AB20-F035AAF70108--