From owner-freebsd-current Wed Mar 20 14:55: 8 2002 Delivered-To: freebsd-current@freebsd.org Received: from melchior.cuivre.fr.eu.org (melchior.enst.fr [137.194.161.6]) by hub.freebsd.org (Postfix) with ESMTP id 7499437B400; Wed, 20 Mar 2002 14:55:03 -0800 (PST) Received: from melusine.cuivre.fr.eu.org (melusine.enst.fr [137.194.160.34]) by melchior.cuivre.fr.eu.org (Postfix) with ESMTP id 309C7865B; Wed, 20 Mar 2002 23:55:01 +0100 (CET) Received: by melusine.cuivre.fr.eu.org (Postfix, from userid 1000) id 7CF3A2C3D1; Wed, 20 Mar 2002 23:55:00 +0100 (CET) Date: Wed, 20 Mar 2002 23:55:00 +0100 From: Thomas Quinot To: John Baldwin Cc: Pierre Beyssac , freebsd-current@freebsd.org Subject: Re: i386/boot2.c patches Message-ID: <20020320235500.A11929@melusine.cuivre.fr.eu.org> Reply-To: thomas@cuivre.fr.eu.org References: <20020320172647.A64459@bofh.enst.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Wed, Mar 20, 2002 at 01:05:31PM -0500 X-message-flag: WARNING! Using Outlook can damage your computer. Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Le 2002-03-20, John Baldwin écrivait : > Looks mostly ok to me. Not entirely sure about the autoboot changes > as it looks weird to load(kname) right before you change what kname > is. I think the logic must somehow be wrong there. But this is what is currently in the code (as I mentioned in the PR, 36015 is strictly a code clarification, with no functional change). The load() function in boot2 ends with an exec() of the loaded binary. It returns only if it has failed. The purpose of replacing kname after load() has returned is to try to load /boot/kernel if we have failed to load /boot/loader. Thomas. -- Thomas.Quinot@Cuivre.FR.EU.ORG To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message