From owner-svn-ports-all@freebsd.org Mon Sep 4 11:41:17 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id 532F1E02346
for <svn-ports-all@mailman.ysv.freebsd.org>;
Mon, 4 Sep 2017 11:41:17 +0000 (UTC)
(envelope-from sunpoet@sunpoet.net)
Received: from mail-oi0-x229.google.com (mail-oi0-x229.google.com
[IPv6:2607:f8b0:4003:c06::229])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(Client CN "smtp.gmail.com",
Issuer "Google Internet Authority G2" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 1AD69704B4
for <svn-ports-all@freebsd.org>; Mon, 4 Sep 2017 11:41:16 +0000 (UTC)
(envelope-from sunpoet@sunpoet.net)
Received: by mail-oi0-x229.google.com with SMTP id t75so1830780oie.3
for <svn-ports-all@freebsd.org>; Mon, 04 Sep 2017 04:41:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=sunpoet-net.20150623.gappssmtp.com; s=20150623;
h=mime-version:sender:in-reply-to:references:from:date:message-id
:subject:to:cc;
bh=R+ZCSNzuyqoXUFw3kI77RfrWGV+2mcWXkfQiyKZIKWk=;
b=1644yF+9qMSVnmH55XHvZJXgFkEkW/WifnnxKGPgMkxyW4I4+hUz6XpDgXSSxB73g8
AugMnRH00Bo5lnb00YmLMwfhy8ofp7JRfe7jc0D+JRgNBGZ5YkgR98LyGdUcg+yeQk0/
9kkBRSY3g7JWTksFI6xjId2dV/Cerrnzybd+5eVUx+8OZO5nbfRtna+9NctrXOifwIlq
deb2kQNtCGGxHgFWNFBS5SY1hi+Fyn93ZVma/gppjqSuy719jNl/dc6NfKjHk82kdyf+
PZbUCy/CCJMoL8LLfeLnyTF38Cq8R2ka4IbAvEnKE4TG62rAJZYiVpg9Rw9s2OqoLyCM
+GXg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
:date:message-id:subject:to:cc;
bh=R+ZCSNzuyqoXUFw3kI77RfrWGV+2mcWXkfQiyKZIKWk=;
b=QehWI4ktIogNy6mvtSfsIkx+3+ZC3jJUxNY9fzTuEF3UDtqDkYM9VoEJXNNinpsGan
IucmbzyL4qekRAtZDBw6nILxOKdSokJPYsk3aoN8XVV9Wu0o1NK9rG6OvGFlrVWO69w7
WpCoJ5XaJboXBPyqCyzVzfybhbk4goNWYzDoZMOemfpbwzjAag2cmaIYw8wSsTuy/62Q
sEeIv1JwEzsavXhHI40KnjBXjHRtpVSLC92gnMukvy2/k5mFrDirZiB6IB3TKCoW942e
lmtlZlAOlxVau7oaTPSoeTFS41LQytq15Ri8h0K3qjZWn9MdbiJOAAXpsdCMVpyvhLyR
ZdyA==
X-Gm-Message-State: AHPjjUgD754ko3893rGDPsCP1Eybk+6D9HCMkpTdRWJR7TonLM22pHnE
CdhX09v3h//LRU93uJgjTbmXbppl7xCT
X-Google-Smtp-Source: ADKCNb4M+D4uye/F909wtK7EZUYTaveMl+8IcwDPXpjP0zcf6l6852bd+ph3ftJu9k0rI+cOlyXYSwyyU4lrbTqrTKA=
X-Received: by 10.202.104.74 with SMTP id d71mr333178oic.83.1504525276139;
Mon, 04 Sep 2017 04:41:16 -0700 (PDT)
MIME-Version: 1.0
Sender: sunpoet@sunpoet.net
Received: by 10.202.252.5 with HTTP; Mon, 4 Sep 2017 04:40:35 -0700 (PDT)
In-Reply-To: <96b4bb9f-dc46-ffea-bd49-a5949b5b7365@FreeBSD.org>
References: <201709031028.v83AS09e027702@repo.freebsd.org>
<96b4bb9f-dc46-ffea-bd49-a5949b5b7365@FreeBSD.org>
From: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>
Date: Mon, 4 Sep 2017 19:40:35 +0800
X-Google-Sender-Auth: FKgg7XGLh19MC0iupY0LGtcHof4
Message-ID: <CAMHz58QxC=GvvQF+Svb78q2ruy38DDx=SDf-fqCoj2VvAg6AMQ@mail.gmail.com>
Subject: Re: svn commit: r449195 - head/security/py-cryptography
To: Kubilay Kocak <koobs@freebsd.org>
Cc: Rene Ladan <rene@freebsd.org>, ports-committers@freebsd.org,
svn-ports-all@freebsd.org, svn-ports-head@freebsd.org,
"python@freebsd.org" <python@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.23
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
<mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
<mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Sep 2017 11:41:17 -0000
On Mon, Sep 4, 2017 at 11:29 AM, Kubilay Kocak <koobs@freebsd.org> wrote:
> On 9/3/17 8:28 PM, Rene Ladan wrote:
> > Author: rene
> > Date: Sun Sep 3 10:28:00 2017
> > New Revision: 449195
> > URL: https://svnweb.freebsd.org/changeset/ports/449195
> >
> > Log:
> > security/py-cryptography: remove support for expired Python 3.3
> >
> > Modified:
> > head/security/py-cryptography/Makefile
> >
> > Modified: head/security/py-cryptography/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- head/security/py-cryptography/Makefile Sun Sep 3 10:12:26 2017
> (r449194)
> > +++ head/security/py-cryptography/Makefile Sun Sep 3 10:28:00 2017
> (r449195)
> > @@ -35,8 +35,6 @@ RUN_DEPENDS+=3D ${PYTHON_PKGNAMEPREFIX}ipaddr
> ess>0:net/p
> >
> > .if ${PYTHON_REL} < 3300
> > RUN_DEPENDS+=3D ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py-enum34
> > -.elif ${PYTHON_REL} < 3400
> > -RUN_DEPENDS+=3D ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py3-enum3=
4
> > .endif
> >
> > post-install:
> >
>
>
Hi,
> Please revert this change:
>
> - It is *meant* to include all versions below 3.4, including 2.7
>
I also got confused when I see it at the first time.
Note the ".elif" which means ${PYTHON_REL} >=3D 3300 and ${PYTHON_REL} < 34=
00.
It only includes python 3.3.
> - It is not necessary to delete when a python language port version is
> removed. The block still semantically and correctly declares the valid
> version dependency requirements from the upstream, independently from
> what the tree has at any point in time.
>
In this case, it should be removed.
devel/py3-enum34 depends on expired python 3.3 only.
>
> Also, if you could, please ask/talk to python maintainers and/or python@
> with regard to port deprecation/deletions before committing. It is not
> always entirely obvious or explicit what is the correct thing to do is
> without fully understanding the versions support and semantics completely=
.
>
I appreciate Ren=C3=A9's help for cleaning up expired ports.
IMHO, if we want to extend the support period, it would be better to change
EXPIRATION_DATE before its expiration.
Regards,
sunpoet
> _______________________________________________
> freebsd-python@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-python
> To unsubscribe, send any mail to "freebsd-python-unsubscribe@freebsd.org"