Date: Wed, 12 Oct 2005 15:21:00 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Michael Nottebrock <lofi@freebsd.org> Cc: jeff@FreeBSD.org, freebsd-current@freebsd.org, csjp@FreeBSD.org Subject: Re: UFS_EXTATTR(_AUTOSTART) broken on 6.0-BETA5 Message-ID: <20051012150600.O48006@fledge.watson.org> In-Reply-To: <200510120041.03079.lofi@freebsd.org> References: <200509220113.06667.lofi@freebsd.org> <20050929221041.H34322@fledge.watson.org> <200509292335.52277.lofi@freebsd.org> <200510120041.03079.lofi@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 12 Oct 2005, Michael Nottebrock wrote: > On Thursday, 29. September 2005 23:35, Michael Nottebrock wrote: > >>> I may have the opportunity to work on this this weekend, but not >>> entirely clear. If Christian is already running with it, I'd much >>> rather let him take this one on as I have a lot of other things on my >>> plate. >> >> Just wanted to make sure it didn't get lost in mailing list traffic, >> thanks! > > Still panics in 6.0RC1. Could you try the attached patch? It appears to work for me here, and I've committed it as ufs_extattr.c:1.82 in HEAD due to a high confidence it's the right fix. I will MFC it for 6.x if it also works for you. Given that extended attributes seem to be getting little testing with UFS1 at this point, I'd appreciate it if you could exercise them as much as possible in testing so we can try to catch any other bugs that may have crept in as the infrastructure around this code changed. Thanks, Robert N M Watson Index: ufs_extattr.c =================================================================== RCS file: /home/ncvs/src/sys/ufs/ufs/ufs_extattr.c,v retrieving revision 1.81 retrieving revision 1.82 diff -u -r1.81 -r1.82 --- ufs_extattr.c 31 Mar 2005 05:58:14 -0000 1.81 +++ ufs_extattr.c 12 Oct 2005 14:18:58 -0000 1.82 @@ -251,6 +251,7 @@ cnp.cn_flags = ISLASTCN; if (lockparent == UE_GETDIR_LOCKPARENT) cnp.cn_flags |= LOCKPARENT; + cnp.cn_lkflags = LK_EXCLUSIVE; cnp.cn_thread = td; cnp.cn_cred = td->td_ucred; cnp.cn_pnbuf = uma_zalloc(namei_zone, M_WAITOK);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051012150600.O48006>