From owner-freebsd-ports-bugs@freebsd.org Mon Mar 16 21:41:32 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 936D8270618 for ; Mon, 16 Mar 2020 21:41:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48h8rW3M6bz45c4 for ; Mon, 16 Mar 2020 21:41:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 50064270611; Mon, 16 Mar 2020 21:41:31 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4ECB5270610 for ; Mon, 16 Mar 2020 21:41:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48h8rW0D5Rz45bQ for ; Mon, 16 Mar 2020 21:41:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A609026D1B for ; Mon, 16 Mar 2020 21:41:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 02GLfU2N083602 for ; Mon, 16 Mar 2020 21:41:30 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 02GLfUWe083601 for ports-bugs@FreeBSD.org; Mon, 16 Mar 2020 21:41:30 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 243857] New Port: /sysutils/xdisk - a partition editor Date: Mon, 16 Mar 2020 21:41:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: adamw@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2020 21:41:32 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243857 Adam Weinberger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adamw@FreeBSD.org --- Comment #7 from Adam Weinberger --- This program looks cool! Some issues: 1) Why is this pulling a single file out of source control? That doesn't se= em ideal. There's no guarantee that that file won't change or disappear in any future commit. Also it seems strange that people checking out from git shou= ld have to download tarballs. Ideally it should be pulling a tag, or a file fr= om releases. 2) All the args to ${INSTALL_PROGRAM} are unnecessary (and the mode is wrong---binaries should be installed 555, as they are by default, and not 7= 55). root:wheel and mode 555 happens automatically. And while we're here: no sla= sh needed after ${STAGEDIR} (${LOCALBASE} starts with a /): ${STAGEDIR}${LOCALBSE}/... 3) The upstream Makefile hardcodes /usr/local, which need to be substituted. See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/slow-pat= ch.html#slow-patch-automatic-replacements 4) Ideally, the Makefile should be getting the glib/gtk/cairo/pango/etc. fr= om pkg-config, not by hardcoding. That's up to developer preference but we'd certainly urge it. --=20 You are receiving this mail because: You are the assignee for the bug.=