From owner-svn-ports-head@FreeBSD.ORG Mon Jul 23 03:15:22 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6FDD8106566C; Mon, 23 Jul 2012 03:15:22 +0000 (UTC) (envelope-from mezz.freebsd@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 2E3BE8FC1D; Mon, 23 Jul 2012 03:15:22 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so10730961pbb.13 for ; Sun, 22 Jul 2012 20:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=OkhgwRYgELSDxSm1cMmvlPfCbqrZqnv5z287lf5DsOw=; b=N4ZcRin70PeOlTkX6SZt39/IGKJNwt05XkfLa9fPqUUpI0tywoXkhoSMlf5ueq2X1i ndg/tmUHhrr8GeuneN5W7mq9854895gRyP/Fzto4HIr/KU+gaX/cbY+hssGOMglevg/K ReKje1cEqRae+04WhhOA9QmXjNPGbR1YYGfswxCz8Oj55XeZMqiONrt2i3wFeCFWw/BX +6ZUWZME2sNE4ZP3zYVYnZwFUPm9Okht0rrUQ5sxIsGsA1IgCEYrWxWOJ+HvSCZqFj/B E61nbRVl21gP+JXH1/xSF5ZbE6gfZ8bZmQVSG0qL9FbBAWROC4hb13RZ1h7c6Zb5Zbp1 uVIw== MIME-Version: 1.0 Received: by 10.68.236.4 with SMTP id uq4mr31310490pbc.158.1343013321791; Sun, 22 Jul 2012 20:15:21 -0700 (PDT) Received: by 10.68.51.201 with HTTP; Sun, 22 Jul 2012 20:15:21 -0700 (PDT) In-Reply-To: <500CB0F7.2090601@FreeBSD.org> References: <201207230133.q6N1XumG049975@svn.freebsd.org> <500CB0F7.2090601@FreeBSD.org> Date: Sun, 22 Jul 2012 22:15:21 -0500 Message-ID: From: Jeremy Messenger To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r301362 - in head: archivers/libcomprex audio/libmtp audio/libsidplay2 cad/adms databases/dbh10 databases/mysqlcppapi devel/bufferpool devel/clanlib devel/compiz-bcop devel/dotconf deve... X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2012 03:15:22 -0000 On Sun, Jul 22, 2012 at 9:03 PM, Doug Barton wrote: > On 07/22/2012 18:47, Jeremy Messenger wrote: >> On Sun, Jul 22, 2012 at 8:33 PM, Doug Barton wrote: >>> Author: dougb >>> Date: Mon Jul 23 01:33:55 2012 >>> New Revision: 301362 >>> URL: http://svn.freebsd.org/changeset/ports/301362 >>> >>> Log: >>> For ports maintained by ports@ where pkgconfig is one of the USE_GNOME deps >>> convert it to BUILD_DEPENDS. This avoids the problem of the bogus run dep >>> added by bsd.gnome.mk. >> >> >> You should wait for bapt@ on this one. He is going to work on USE_PKGCONFIG. > > If bapt's solution materializes, and if it's appropriate for these > particular ports, then it can still be utilized. The only thing that is > different now is that these ports match a different grep pattern, one > that will have to be searched for anyway. > > IOW, this change doesn't hurt anything long term, and it does solve the > bogus run-dep problem now. It doesn't hurt, but you are making more work for bapt by chase all of your change. bapt wants to add WANT_PKGCONFIG to allow us to choice either pkg-config or pkgconf, so that line will be changed either. > Oh, and for this set of ports removing USE_GNOME is a double feature, > since it didn't need to be included there in the first place. > > Doug > > -- > > Change is hard. -- mezz.freebsd@gmail.com - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org