Date: Thu, 13 Jul 2017 14:21:27 +0100 From: Matthew Seaman <matthew@FreeBSD.org> To: "Miller, Vincent (Rick)" <vmiller@verisign.com>, "freebsd-ports@freebsd.org" <freebsd-ports@freebsd.org> Subject: Re: FW: build for py27-sispy-1.0.1 in patch Message-ID: <60581776-dc25-659f-7c3b-fe46ccce257a@FreeBSD.org> In-Reply-To: <FDEFB834-0B38-42E2-9685-9EE77ACBB756@verisign.com> References: <FDEFB834-0B38-42E2-9685-9EE77ACBB756@verisign.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SswMAqtuPAjdj6wG9au8VD9x3E4UoS94i Content-Type: multipart/mixed; boundary="5XPR1TmKgGj41P9kP2OIATGp7fFQWFm1X"; protected-headers="v1" From: Matthew Seaman <matthew@FreeBSD.org> To: "Miller, Vincent (Rick)" <vmiller@verisign.com>, "freebsd-ports@freebsd.org" <freebsd-ports@freebsd.org> Message-ID: <60581776-dc25-659f-7c3b-fe46ccce257a@FreeBSD.org> Subject: Re: FW: build for py27-sispy-1.0.1 in patch References: <FDEFB834-0B38-42E2-9685-9EE77ACBB756@verisign.com> In-Reply-To: <FDEFB834-0B38-42E2-9685-9EE77ACBB756@verisign.com> --5XPR1TmKgGj41P9kP2OIATGp7fFQWFm1X Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2017/07/13 14:02, Miller, Vincent (Rick) via freebsd-ports wrote: > A new port request (PR #219823) for py-sispy, of which I am > maintainer, was recently committed to ports=E2=80=99 HEAD though the co= de > committed differs slightly from the code submitted in that sources > are pulled from CHEESESHOP vs GitHub. The sources at CHEESESHOP do > not contain the license file -- resulting in a failed build -- while > the LICENSE file _does_ exist on GitHub and results in a built > package. distinfo has also changed because of this. >=20 > Is the change from USE_GITHUB to MASTERSITES=3DCHEESESHOP necessary? > The port builds fine when sources are pulled from GitHub. According > to the author, GitHub is the official source repo for the project. >=20 > Please =E2=80=9Creply-all=E2=80=9D as this email address is not subscri= bed to this > list. >=20 The convention for py- ports is that they should use MASTERSITES=3DCHEESESHOP unless there are good reasons to use some other location. Not having a copy of the license file in the distfile is not generally sufficient reason on its own to avoid pypi -- the port should simply set LICENSE but not LICENSE_FILE. Ensuring a degree of consistency amongst a whole class of ports is a good thing in that it reduces the amount of code overall that needs to be maintained. It helps maintainers and ports committers by keeping things similar and familiar. However, having said that, none of the conventions in the ports are so strict that exceptions cannot be made. You just need to show that doing it differently simplifies or clarifies the port or results in some other valid benefit. If deleting the LICENSE_FILE line from your py-sispy port fixes the problem (and I believe it will) then my advice would be to switch to CHEESESHOP. Cheers, Matthew --5XPR1TmKgGj41P9kP2OIATGp7fFQWFm1X-- --SswMAqtuPAjdj6wG9au8VD9x3E4UoS94i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQJ8BAEBCgBmBQJZZ3PdXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQxOUYxNTRFQ0JGMTEyRTUwNTQ0RTNGMzAw MDUxM0YxMEUwQTlFNEU3AAoJEABRPxDgqeTn53MP/0YhmTr9ko/RnH5YtBB8m/+Q iPLTKvStaIQmG6goa/SvrbEvTiA9xKZVoL2WyDOMcdMatxFbRbhLaybF3cCnnE4F z0cRrrRyhNQ+SlhivrP18B8kh+dM9ZyHpD7nOGql+HQv8zLG+Bbzxg3Ce6fSbvK5 Qc4kYVfryEspnbgVKDMx2VcJ1Jd374GQ6hls1tF03kqtxEDSVlDsDcQbfPNFWV1v pcYU7l4BY5Zv8fGs25RjrsY7Vx4fDyjFU4H313O7F7ukHI5a9v9n6ZtRsof+gBeU Q87HP2ObeJSfBwuNCarUtGOSG9mqenu60ZDLdjvPZABXbDZZk0DJ1iUVeNyeJ2KB auoXcKqW5ODvvBmKkVKALuaGzNreLvQb7PFDGxz7ytS0T86zK+6rch4hpwth3zPD 48RN5gdWoeIwAJiJoWE0VZPEe2C6bTIXsIOKSX4pIdN3jnbscz71iDgqr+YizzkM SjBmar0wJ6NwYrsYZtzagnf7PWe29iSce+G41o7X8GAgBMAeV+MMtbR3v9U2+a26 dLKqnwJc6izibDYpn5mmThHMhAHllxraojztl1JN2oO5Jwt7Q00w5lTWsdIXuM8M VaeH+UD3X2Do1HYN8sKE3h5qSojX8X8YUKivvfRsmBPHWoHESA5iAwv0rtL/6Gnh 7hDr9L+cBcn29TUv61Pm =db2n -----END PGP SIGNATURE----- --SswMAqtuPAjdj6wG9au8VD9x3E4UoS94i--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?60581776-dc25-659f-7c3b-fe46ccce257a>