From owner-svn-src-all@freebsd.org Tue Sep 3 14:06:46 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6AC48DC730; Tue, 3 Sep 2019 14:06:19 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zG00yjz4PPJ; Tue, 3 Sep 2019 14:06:18 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 7667D1A44A; Tue, 3 Sep 2019 14:06:04 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id EA49413170; Fri, 5 Apr 2019 20:30:02 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4477073C66; Fri, 5 Apr 2019 20:30:02 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 1C6F51310C; Fri, 5 Apr 2019 20:30:02 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 8BD65130F8; Fri, 5 Apr 2019 20:29:59 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 23EF173C4F; Fri, 5 Apr 2019 20:29:58 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x35KTuEN041159; Fri, 5 Apr 2019 13:29:56 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x35KTuCo041158; Fri, 5 Apr 2019 13:29:56 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201904052029.x35KTuCo041158@gndrsh.dnsmgr.net> Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs In-Reply-To: To: Enji Cooper CC: rgrimes@freebsd.org, cem@freebsd.org, Ed Maste , Xin LI , src-committers , svn-src-all , svn-src-head Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 4477073C66 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:46 -0000 X-Original-Date: Fri, 5 Apr 2019 13:29:56 -0700 (PDT) X-List-Received-Date: Tue, 03 Sep 2019 14:06:46 -0000 > On Apr 5, 2019, at 13:22, Rodney W. Grimes wrote: > > >>> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: > >>> > >>>> On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: > >>>> > >>> > >>>>> +static const u_char dot_name[] = { > >>>>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > >>>>> +static const u_char dotdot_name[] = { > >>>>> + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > >>>>> + > >>> > >>> They are all either '.' or ' ', the commas are just list separators. > >>> IMO spaces after the commas would make it slightly easier to see. > >> > >> Would it make sense to just use the normal string syntax for char > >> array assignment? > >> > >> static const u_char dot_name[11] = ". "; > >> static const u_char dotdot_name[11] = ".. "; > >> > >> Seems more clear to me. > > > > To try and end this thread, I already stated it was in review, > > let me get a pointer to it, if you have comments please post > > them there: > > https://reviews.freebsd.org/D19829 > > It would probably be a good idea to add a comment in the code to document the intention. > Thanks, Again, there is a review up, D19829, please comment there. > -Enji -- Rod Grimes rgrimes@freebsd.org