From owner-cvs-src@FreeBSD.ORG  Wed Oct 27 19:02:23 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 592B516A4CF; Wed, 27 Oct 2004 19:02:23 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4DFA443D48; Wed, 27 Oct 2004 19:02:23 +0000 (GMT)
	(envelope-from bms@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9RJ2NuI009029;
	Wed, 27 Oct 2004 19:02:23 GMT
	(envelope-from bms@repoman.freebsd.org)
Received: (from bms@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9RJ2Nui009028;
	Wed, 27 Oct 2004 19:02:23 GMT
	(envelope-from bms)
Message-Id: <200410271902.i9RJ2Nui009028@repoman.freebsd.org>
From: Bruce M Simpson <bms@FreeBSD.org>
Date: Wed, 27 Oct 2004 19:02:23 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/pci if_vr.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Oct 2004 19:02:23 -0000

bms         2004-10-27 19:02:23 UTC

  FreeBSD src repository

  Modified files:
    sys/pci              if_vr.c 
  Log:
  Forcibly disable interrupts, if we find ourselves servicing one when
  the device is suspended or shutting down. This will need to be rethought
  slightly if we implement suspend/resume support within vr(4).
  This appears to fix the vr_shutdown() panic on SMP machines.
  
  My theory here is there's a race somewhere during vr_detach() with
  vr_intr() in the SMP case which was sometimes being triggered,
  although quite why this was happening is unclear (vr_stop() also
  explicitly disables interrupts by writing to the IMR register).
  
  MFC-to-RELENG_5* candidate.
  
  PR:             kern/62889
  Tested by:      seb at struchtrup dot com
  MFC after:      10 days
  
  Revision  Changes    Path
  1.99      +8 -1      src/sys/pci/if_vr.c