From owner-svn-src-head@freebsd.org Tue Nov 14 17:00:56 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F7D3DD7507 for ; Tue, 14 Nov 2017 17:00:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D6BEE65B8B for ; Tue, 14 Nov 2017 17:00:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x234.google.com with SMTP id 189so25074806iow.10 for ; Tue, 14 Nov 2017 09:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=aVZVkTsimYXL2kdaGxVqYOKqaLvLtNgK6Xn3dI6Qbs8=; b=V0mJWS73JvO1CvqrrfvqMctH5CXIUiWVCCJWhMgeNhMZQRfbeBP+9tiJz5LtW5oi+y up6OuZDpU26vW5aV/RVfWoNufM7Dzev0HKaqKa5PPk73RRnSBHXOTjzAF8FfZyugw64f GNqjDX1hHZnUkW7+3jO9t60zyeb3PgdyTQhQhuY2/o2uSxYOp6kA2vNOMPGiD6rWDV0R lfwo1fZwjKjK/tvrsb4t/xUr7EdKCUtPz14XEL1F+50Rs6euafml87nVgtV/a71Y0WWX xoX2TITEPWZBQoS0I0VzuKICzN9Oo6JgupXD9yiDQ8atrGNDlFpR1i9lQScsYegLim+u dK/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=aVZVkTsimYXL2kdaGxVqYOKqaLvLtNgK6Xn3dI6Qbs8=; b=HEk0/UZDG3eLjG6KBN79rerMj+Qgu8Ut6JfgWEViq3+DVVAkNMJnnOckEVoseF0b62 3jpP9nxgfTco7sPxAiZKXLeOtWF5yurCGTxctbLRYyweJZyQa6a5m8zY3zu5lGKKV75u PH43HMMAVCerj3O+XH4s7OH6qqdRq4D0OdrRC1MwyJ/KiRUmONTNQaG2CIE1a6Q/84rh jaWZbdIjVb/L4A2jPsouWzjjRux5LWGLhKzaWrheNO0OULxNZEwVNiFcPvsgpKSXHe6M qjhLY5eapTTYwMe2vQd+mzaot9i6EGg4y/0g0rq2gIqgo+228chVSPAJvYvhsRAeWWjT Y07A== X-Gm-Message-State: AJaThX4apFICTQFp+PuYYSs1YwLMQJednLoctde0wZ/iXGyICtKcg3F0 tf63HQxWh2Z0t+X72LHBb+1iox+CkbC4NH/7VozfNg== X-Google-Smtp-Source: AGs4zMbcDIUy/JcLtgT/S4RfkSwajxHgLunBFvjEjQkfQAEIrUTHoAq+bEwKwIk9QOKMBq/GAzsNpDAAttTs4RX5OIg= X-Received: by 10.107.48.195 with SMTP id w186mr180705iow.301.1510678854755; Tue, 14 Nov 2017 09:00:54 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Tue, 14 Nov 2017 09:00:54 -0800 (PST) X-Originating-IP: [50.253.109.65] In-Reply-To: <1911777.0IZEGYVEAQ@ralph.baldwin.cx> References: <201711140505.vAE555QF042553@repo.freebsd.org> <1911777.0IZEGYVEAQ@ralph.baldwin.cx> From: Warner Losh Date: Tue, 14 Nov 2017 10:00:54 -0700 X-Google-Sender-Auth: U9pHCW7YgS_h4zWAOpxuWTdiAwI Message-ID: Subject: Re: svn commit: r325793 - head/sys/dev/pci To: John Baldwin Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2017 17:00:56 -0000 On Tue, Nov 14, 2017 at 8:47 AM, John Baldwin wrote: > On Tuesday, November 14, 2017 05:05:05 AM Warner Losh wrote: > > Author: imp > > Date: Tue Nov 14 05:05:05 2017 > > New Revision: 325793 > > URL: https://svnweb.freebsd.org/changeset/base/325793 > > > > Log: > > Provide pcie_link_status and pcie_link_cap convenience functions. > > > > Sponsored by: Netflix > > Note that we already have pcie_read_config() (documented in the manpage). > With pcie_read_config() these would be one liners: > > pcie_link_status() -> pcie_read_config(dev, PCIER_LINK_STA, 2); > > This is what the existing hotplug code uses rather than having dedicated > functions for each PCI-e register. > > New functions should be documented in pci.9. > Thanks for the reminders. I'll either transition to the one liner you talked about, or document the new functions. Warner