From owner-freebsd-current Thu Jun 20 14:39:17 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA11430 for current-outgoing; Thu, 20 Jun 1996 14:39:17 -0700 (PDT) Received: from vector.jhs.no_domain (slip139-92-42-134.ut.nl.ibm.net [139.92.42.134]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id OAA11397; Thu, 20 Jun 1996 14:38:53 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by vector.jhs.no_domain (8.7.5/8.6.9) with SMTP id DAA04427; Thu, 20 Jun 1996 03:05:38 +0200 (MET DST) Message-Id: <199606200105.DAA04427@vector.jhs.no_domain> X-Authentication-Warning: vector.jhs.no_domain: Host localhost [127.0.0.1] didn't use HELO protocol To: "Jordan K. Hubbard" cc: current@FreeBSD.org Subject: Re: xditview From: "Julian H. Stacey" Reply-To: "Julian H. Stacey" Organization: Vector Systems Ltd. Address: Holz Strasse 27d, 80469 Munich, Germany Phone: +49.89.268616 Fax: +49.89.2608126 (later) Web: http://www.freebsd.org/~jhs/ Mailer: EXMH 1.6.7, PGP available In-reply-to: Your message of "Wed, 19 Jun 1996 02:10:34 PDT." <22303.835175434@time.cdrom.com> Date: Thu, 20 Jun 1996 03:05:38 +0200 Sender: owner-current@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk Hi, Reference: > From: "Jordan K. Hubbard" > Subject: Re: xditview > Date: Wed, 19 Jun 1996 02:10:34 -0700 > Message-id: <22303.835175434@time.cdrom.com> > > > Shudder ... `unbundling' Eh ? > No, rebundling. > > > Stripped down op. systems with optional C compiler & text processing system - s > ? > > No. Everything which is there will remain, just differently encapsulated. > > > however, there might be a benefit to not having to BSD-make convert > > the mega FSF distribs such as gcc & groff etc, each time they upgrade. > > Yes! > > Jordan Thanks for answering the side issues, now please don't over look the main issue ;-) > To: "Jordan K. Hubbard" > Cc: current@FreeBSD.org > Subject: Re: xditview > From: "Julian H. Stacey" > Date: Wed, 19 Jun 1996 01:59:45 +0200 > > Hi, Reference: > > From: "Jordan K. Hubbard" > > > > Well, if ones source tree were 99% X source code free, wouldn't you be > > tempted to go for that final 1%? :-) > > Yes, If it had never gone in it would have been fine, > or if it had been in only a short while, > but it seems dubious from a quality control viewpoint, to now remove > a facility CD users have had at least 2 releases to get used to having > available (2.0.5 & 2.1). > > A simple .if exist .... SUBDIR += would suffice, wouldn't it ?. Accepting Mike's subsequent comment: > From: Michael Smith > Subject: Re: xditview > To: jhs@freebsd.org > Date: Wed, 19 Jun 1996 09:32:38 +0930 (CST) > Cc: current@freebsd.org, jkh@freebsd.org > > Actually, it would cause 'make world' to fail if /usr/X11R6 were present > but not complete (eg. only libraries were present, say for running emacs), > or not writable (eg. mounted readonly via NFS), or if you built on a > machine with no X and then tried 'make reinstall' onto one that had > X, the 'reinstall' would fail. > > > A better solution may be something like: > > src/gnu/usr.bin/groff/Makefile: > > .if exists(${X11BASE}/include) > > .if exists(${X11BASE}/lib) > > SUBDIR +=xditview > > You would need to add a writability test too. I would have been happy > with the build or install failing and being ignored, but I couldn't > come up with a way for it to be done tidily. As you (I believe) too crudely nuked the tree, IMO it's your responsibility to repair the damage your butchery has inflicted, & find some better solution, even if no better than a crude: src back out of Attic, & .if defined(XDITVIEW) SUBDIR +=xditview. I can't believe you would want to forget the issue, and just leave the butchery unfixed. It's unprofessional to toss out functionality, without careful consideration & list discussion, now we realise that at least 2 previous public releases of our FreeBSD product has offered xditview facility to users. Julian -- Julian H. Stacey jhs@freebsd.org http://www.freebsd.org/~jhs/