Date: Fri, 12 Mar 1999 20:32:39 +0100 From: Mark Hannon <mark.hannon@stockholm.mail.telia.com> To: freebsd-ports@freebsd.org, se@freebsd.org Subject: [Fwd: Patch to (partially) fix tar problems in kfm] Message-ID: <36E96BD7.1E177D88@stockholm.mail.telia.com>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------9CC0D351CEDB558473D5D2D8
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Hi,
Here is a copy of an email I just sent to the KDE guys. Maybe it could
be included as
one of the patches in the port?
Rgds/Mark
--------------9CC0D351CEDB558473D5D2D8
Content-Type: message/rfc822
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <36E96B82.31B085D1@stockholm.mail.telia.com>
Date: Fri, 12 Mar 1999 20:31:14 +0100
From: Mark Hannon <mark.hannon@stockholm.mail.telia.com>
X-Mailer: Mozilla 4.5 [en] (X11; I; FreeBSD 3.1-STABLE i386)
X-Accept-Language: en
MIME-Version: 1.0
To: coolo@kde.org, faure@kde.org
Subject: Patch to (partially) fix tar problems in kfm
Content-Type: multipart/mixed;
boundary="------------5F74E36C08D8D5E03081C4B9"
This is a multi-part message in MIME format.
--------------5F74E36C08D8D5E03081C4B9
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Hi,
I am running FreeBSD-3.1 along with kde-1.1. I have had some problems
with kfm and
it's handling of tar files. This worked (sorta) in kde-1.0 but stopped
working in kde-1.1.
After looking through the code I think Ihave nailed down the cause for
that particular
problem. (See attached patch for the tar.cpp file)
Kfm is still not working 100% with tar files, it seems to work (mostly)
for tar.gz files
but does not work for a plain tar file. I spent a couple of hours
trying to work it out but
my c++ and Qt knowledge wasn't up to scratch.
Hope the patch is useful.
Regards/Mark
--------------5F74E36C08D8D5E03081C4B9
Content-Type: text/plain; charset=us-ascii;
name="tar.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="tar.patch"
*** tar.cpp Fri Mar 12 20:22:11 1999
--- tar.cpp.orig Fri Mar 12 20:20:49 1999
***************
*** 213,222 ****
// extracting /xxx from a tarfile containing the file xxx won't work
while( dirpath[0] == '/' ) dirpath.remove(0,1);
! // FreeBSD doesn't like it if there is a trailing slash ...
! int stringlength = dirpath.length();
! while( dirpath[stringlength-1] == '/' ) dirpath.remove(stringlength-1,1);
!
QString Command( "tar -%stvf -");
if (dirpath[0] != '\0')
{
--- 213,219 ----
// extracting /xxx from a tarfile containing the file xxx won't work
while( dirpath[0] == '/' ) dirpath.remove(0,1);
!
QString Command( "tar -%stvf -");
if (dirpath[0] != '\0')
{
--------------5F74E36C08D8D5E03081C4B9--
--------------9CC0D351CEDB558473D5D2D8--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?36E96BD7.1E177D88>