From owner-trustedbsd-audit@FreeBSD.ORG  Fri Dec 15 08:25:44 2006
Return-Path: <owner-trustedbsd-audit@FreeBSD.ORG>
X-Original-To: trustedbsd-audit@FreeBSD.org
Delivered-To: trustedbsd-audit@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 29B1916A4B3
	for <trustedbsd-audit@FreeBSD.org>;
	Fri, 15 Dec 2006 08:25:44 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0A96643CCB
	for <trustedbsd-audit@FreeBSD.org>;
	Fri, 15 Dec 2006 08:24:00 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id B7B0A46E59;
	Fri, 15 Dec 2006 03:25:39 -0500 (EST)
Date: Fri, 15 Dec 2006 08:25:39 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Diego Giagio <dgiagio@gmail.com>
In-Reply-To: <4560D883.7040409@gmail.com>
Message-ID: <20061215082453.R29087@fledge.watson.org>
References: <4560D883.7040409@gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: trustedbsd-audit@FreeBSD.org
Subject: Re: OpenBSM compiler warnings patch
X-BeenThere: trustedbsd-audit@FreeBSD.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: TrustedBSD Audit Discussion List <trustedbsd-audit.FreeBSD.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-audit>, 
	<mailto:trustedbsd-audit-request@FreeBSD.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/trustedbsd-audit>
List-Post: <mailto:trustedbsd-audit@FreeBSD.org>
List-Help: <mailto:trustedbsd-audit-request@FreeBSD.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-audit>, 
	<mailto:trustedbsd-audit-request@FreeBSD.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Dec 2006 08:25:44 -0000


On Sun, 19 Nov 2006, Diego Giagio wrote:

> I've created a patch that removes all the compiler warnings I was getting, 
> mostly signed/unsigned stuff.
>
> bsm_io.c: I've sticked with the following rules to resolve the conflicts:
>
> - Buffers are u_char*
> - Strings are char* (or const char*)
> - Casts are used when pointing strings inside buffers.
>
> bsm_notify.c: notify_check function on my Mac OS X 10.4.8 expects an int on 
> the second parameter, not an unsigned int.
>
> bsm_token.c: au_to_newgroups expect a gid_t* on the second parameter, not an 
> int*. In fact a gid_t may expand to an int or even an unsigned int.
>
> Instructions:
> $ cd openbsm
> $ patch -p1 < warnings.patch
>
> Please review.

Diego,

Sorry for the long delay in getting back to you on this.  I've installed gcc41 
on my desktop box, confirmed the warning fixes, and merged to Perforce.  These 
changes will appear starting in OpenBSM 1.0 alpha 14.

Thanks!

Robert N M Watson
Computer Laboratory
University of Cambridge