From nobody Mon Jun 16 21:01:26 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bLj963TBRz5yPss; Mon, 16 Jun 2025 21:01:30 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bLj961pDDz3rWC; Mon, 16 Jun 2025 21:01:30 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750107690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S3uDpRa20SeEaudTHLMv6kwVr6x0pxHj5ayowIH65hQ=; b=dTHmMhQzEzgSVqZKPI7EbySK9L+vHebEkyKTrpYNkmwaXl8GYJKu7A/VSf22x2URLJk6QJ Bmf8GU0/oqXfaZzPD26J9f5FknmetRpTb574rlVbhwi1Plon5oBSlC5ezlQ0eZfsl7tmbv 1X4b0jUg0+EZ7rHT5VG7/9HGYDazthJ44TMH+BQK6vanwnWi6LlmP9ovU6Mith88wdCxk/ wNJt7bd9q0bmsFG+F+ZLouTHK1yCAoUq2jQGV43hXZMjohPi7Xm5XYgWIcqhBZqRo+5hG7 uqmDZDOgNuqYrwXkHO2Ve5bn8+etUFhmJ9JGEfXJMAkP0ir3sL+vkqgecpFGIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750107690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S3uDpRa20SeEaudTHLMv6kwVr6x0pxHj5ayowIH65hQ=; b=U34JfRGBtPAYbQLtEZVbpBt71T2GYedJNKsU0+sIB+zfQRKjW6uk2P8nFBwIb+nj8bZdPu 0VTeyS13cDfmRr3GS7F6zlz4PrqCOn+HphPxShFF7wH1gbWq5o4WpupQ5EGk4Ce94/PjLH I/XjJGGsDUEtVUEXQARoPhk5+In8e6ut5bq6Lq37NxNDbq4qIjK/BcIiyZ0IT49a6JqKt+ aNWCFZUttqyFw6q5krNuOa3QQwaUJqLbFT0lUF7WgmryMN+L7pIZDKBnqR1pDEA24pI4HG FdId3Q02gqAR3lNHg9G95Sd4D9mugp88l3Go8+ZfE+22k8U+yQ/PeMglkAeZ+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1750107690; a=rsa-sha256; cv=none; b=k35dQyF1wKfdPRxWFADkiHy+V3htlL1iqJplH+OIB4WXqr6dCW5jAnRPXiIhdzH/knK2IR XrBzPE80pupn+2ej8z28RTh6eP4Ti3VJXKOD+paczCHn/DNYhZqnoblh+k/wL1sGy01cCQ 9Q05dAj6KuS/SOh/VBo9v2AwjlnTRzShRZCoiTT+jVlbjRbVIOAj4QuomQjubKR5ZtWg+/ iTx0jmDFBVA0hjImSxjcWEOvDH4JTgTBH1KyYYNmIosey78Y+xWeUsc07t8lYtmL0jO6OE CAgtyl2r1o8gudAZlkj+a1Z6brvwS/8xWeyYDwPlO7Kx2HoXnhlyOpLtBKGCRA== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bLj952cgdzsbV; Mon, 16 Jun 2025 21:01:29 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Mon, 16 Jun 2025 14:01:26 -0700 From: Gleb Smirnoff To: Mark Johnston Cc: John Baldwin , Konstantin Belousov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4e207e3849d4 - main - exterr: make SET_ERRORX() macros an expression evaluating to the errno Message-ID: References: <202506131940.55DJeTa1046740@gitrepo.freebsd.org> <0003a97e-60ed-4868-8844-0a0346bc97ee@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jun 14, 2025 at 08:59:39AM -0400, Mark Johnston wrote: M> If your suggestion is implemented, then it would be sensible to use a M> different name to avoid collisions, maybe SET_EXTERROR() or just M> EXTERROR(). I'd vote for EXTERROR(). But now with the function existing, why would we recommend to use the macro instead of the function at all? IMHO, the function shall be the right use and that will make any macro collisions with ZFS or whatever void. -- Gleb Smirnoff