From owner-cvs-src@FreeBSD.ORG Sat Feb 10 02:18:47 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D588016A400; Sat, 10 Feb 2007 02:18:47 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.freebsd.org (Postfix) with ESMTP id 9057C13C481; Sat, 10 Feb 2007 02:18:47 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.8/8.13.8) with ESMTP id l1A2Idha091862; Fri, 9 Feb 2007 18:18:47 -0800 (PST) (envelope-from mjacob@freebsd.org) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id l1A2Id8b091859; Fri, 9 Feb 2007 18:18:39 -0800 (PST) (envelope-from mjacob@freebsd.org) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Fri, 9 Feb 2007 18:18:38 -0800 (PST) From: mjacob@freebsd.org To: cokane@cokane.org In-Reply-To: <346a80220702091559o39c68934n5197f34d01d06231@mail.gmail.com> Message-ID: <20070209181154.B91424@ns1.feral.com> References: <200702091903.l19J3Ik5099479@repoman.freebsd.org> <20070209211517.GI1620@funkthat.com> <20070209221913.GA11826@lor.one-eyed-alien.net> <346a80220702091559o39c68934n5197f34d01d06231@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, John-Mark Gurney , Brooks Davis , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/conf GENERIC src/sys/i386/conf GENERIC src/sys/ia64/conf GENERIC src/sys/pc98/conf GENERIC src/sys/powerpc/conf GENERIC src/sys/sparc64/conf GENERIC src/sys/sun4v/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mjacob@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Feb 2007 02:18:48 -0000 > > > I prefer that last option. Uniquify them somehow, and perhaps spit a warning > out to console. "LABEL: ufs/xxxx on device ad4s1b renamed to ufs/xxxx1". > Maybe just force it to auto-increment that last number until it finds an > available slot. If it can't find an available slot, then spit out an error > about ambiguous GEOM labels.... This is exactly what I did for the g_multipath stuff. There is *some* notion of UUID in most of the GEOM label types- I did it as a more explicit real UUID, but the crux of the biscuit is what is the real unique id? Ascii names are useful, but they aren't usually veru unique. How many "oracle" labels will people pick? The choice I made is that the UUID is the *real* id. The ascii name is a 'convenience' name. If in a multipath or shared SAN environment, there is an ascii name collision during the taste operation, you can and do still build the geom but have to frob the name. Any kind of frob is okay because any automount using the ascii name is now going to fail. An alternative is to export the UUID as a name, which is probably the right thing to do also. This, btw, has come up for years (since RedHat 9) in Linux. The installer will pick "/boot" and "/" as the LABEL= qualifiers, which is a complete lose in a SAN or even in a multiboot non-shared environment, so I invariably change the LABEL= to UUID= qualifiers in both grub.conf and /etc/fstab. -matt