From owner-freebsd-hackers@FreeBSD.ORG Fri Aug 4 18:21:28 2006 Return-Path: X-Original-To: freebsd-hackers@FreeBSD.org Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9AF4916A4DA; Fri, 4 Aug 2006 18:21:28 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC47443D5D; Fri, 4 Aug 2006 18:21:27 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k74ILOuE037815 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Aug 2006 22:21:25 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k74ILOCf037813; Fri, 4 Aug 2006 22:21:24 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 4 Aug 2006 22:21:23 +0400 From: Gleb Smirnoff To: Joao Barros Message-ID: <20060804182123.GH96644@cell.sick.ru> References: <70e8236f0608030735m519d880fgebeca7108b859244@mail.gmail.com> <20060804150302.GD96644@cell.sick.ru> <70e8236f0608040848x304a671cle6d490f43735737b@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <70e8236f0608040848x304a671cle6d490f43735737b@mail.gmail.com> User-Agent: Mutt/1.5.6i Cc: freebsd-hackers@FreeBSD.org, Julian Elischer Subject: Re: [PATCH] add header "pppoe:" in ng_pppoe.c printfs X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 18:21:28 -0000 On Fri, Aug 04, 2006 at 04:48:49PM +0100, Joao Barros wrote: J> On 8/4/06, Gleb Smirnoff wrote: J> >On Thu, Aug 03, 2006 at 03:35:04PM +0100, Joao Barros wrote: J> >J> Being this a cryptic message to say the least and to probably save J> >J> someone some time when presented with this message I attach a patch J> >J> that adds the header "pppoe:" in every printf that didn't have it, J> >J> making it consistent with the rest of the file. J> > J> >I've attached a patch that cleans a bit logging in ng_pppoe. It changes J> >all printf(9) to log(9). The latter is better since it spams console J> >less, if event occurs many times per second. Also I've made the messages J> >more clear - prepended node ID where possible, function name when it J> >starts with ng_pppoe, or just "ng_pppoe". J> > J> >Can you please try out this patch and tell whether you like it. If you J> >do I will commit it soon. J> J> Hi, J> J> I've looked at the patch and it looks ok. J> It serves the purpose: make the messages more clear with the added J> bonus of more info. J> Thanks for taking the time to look into this :-) Since I don't use ng_pppoe now much, I'd appreciate if you do at brief test of this patch, before I commit it. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE