From nobody Mon Apr 1 21:09:20 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V7kCh4Ys2z5GsMM for ; Mon, 1 Apr 2024 21:09:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V7kCh3W7jz46b0 for ; Mon, 1 Apr 2024 21:09:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712005760; a=rsa-sha256; cv=none; b=gfhJ5Bou+nT7xiELftE46PdaDXlRFfKXD+YXPyzxrL35vWh0zbDThfhbdtisx97ohUzwxF fiPkvoWUfVgTpam44yH15c4hXjYM0caWmPWOM3zGaxRikVO8BT84adspR3HuVEMTotoQ2Y Pl6cqo853SM95CB4AzP99n6OcEJj8FkHEkDhUBg8odz+I8VVa0OwQol2kePyyqlN78czOp /izq8Q2SaVYCHnNQUxgUJoqNqsBNleaq5gUDhnvm+R75ArausHkYq+3P+vk01HtTcu369V LYiUJSPY0iUd5ePEPy2MsuYl7wlccjxcZjZPiX9AOncS3zWVh5nlE3vqetMTrg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712005760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8ptQkoXHQY/78tgW3JV9Gax7ajZqMndYDd7nIjosD0Y=; b=eEP9D28QzszOoFPKVt40yB7byDYE1i0DGGoaNtdQoj3WN9FyXek0rMYuyXgCcL56UTGKG3 wNDNfV8x7OZS2V7qMpsE6zQlaqx6m/IElXqVvO6SDWlj04fLoLgoEuK3AdGcNjM1qDSLAb PrtBSzGj4Fk/oHwZXRghxcUSMl6DFYQglP56pwXiAr9qIs9+YnBcFS0wROhazfla8Um1nL ka5yQvIWwasDE5rvuC2vM4Vae2wfrcwIane0HgYjWSYU1VdEBQ4WUG9qxWuBH+hKtBDEpy EHFJ39Ur6Z6ZJTLmMJmPVCMQ2MnXLZfzgY2ZIAIdOrnBzLY78ET1RDHnQE7KHA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4V7kCh2yhdzLqj for ; Mon, 1 Apr 2024 21:09:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 431L9Kim067159 for ; Mon, 1 Apr 2024 21:09:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 431L9KuT067158 for ports-bugs@FreeBSD.org; Mon, 1 Apr 2024 21:09:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 278117] games/openttd: Patch adds insecure functionality Date: Mon, 01 Apr 2024 21:09:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: charlespigott@googlemail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: danfe@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D278117 Bug ID: 278117 Summary: games/openttd: Patch adds insecure functionality Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: danfe@FreeBSD.org Reporter: charlespigott@googlemail.com Flags: maintainer-feedback?(danfe@FreeBSD.org) Assignee: danfe@FreeBSD.org There is a patch in the OpenTTD port that adds functionality to save passwo= rds from network games out to a file (presumably so they can be reloaded again = on restart). This was added quite some time ago, in 2014, for no reason that I can tell = just from the commit. https://gitlab.com/FreeBSD/freebsd-ports/-/blob/main/games/openttd/files/ex= tra-patch-save-passwords Even though this patch is guarded by a WITH_SAVE_PASSWORDS define, it feels very wrong that the official port should make any changes to the functional= ity of the program, and certainly not one that saves passwords out in plain tex= t to an arbitrary file. (Incidentally, OTTD will likely have some actual password saving feature for the next major release with actual cryptographically secure storage, but th= at work is still ongoing) --=20 You are receiving this mail because: You are the assignee for the bug.=