From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Mar 15 05:00:15 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57D8816A4FE for ; Mon, 15 Mar 2004 05:00:15 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3AEFF43D2F for ; Mon, 15 Mar 2004 05:00:15 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i2FD0Fbv021152 for ; Mon, 15 Mar 2004 05:00:15 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i2FD0Fn4021151; Mon, 15 Mar 2004 05:00:15 -0800 (PST) (envelope-from gnats) Resent-Date: Mon, 15 Mar 2004 05:00:15 -0800 (PST) Resent-Message-Id: <200403151300.i2FD0Fn4021151@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Edwin Groothuis Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F308416A4CE for ; Mon, 15 Mar 2004 04:50:30 -0800 (PST) Received: from mailout2.barnet.com.au (mailout2.barnet.com.au [218.185.88.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 24D3543D31 for ; Mon, 15 Mar 2004 04:50:30 -0800 (PST) (envelope-from edwin@mavetju.org) Received: by mailout2.barnet.com.au (Postfix, from userid 27) id 55D35AA61E2; Mon, 15 Mar 2004 23:50:28 +1100 (EST) Received: from mail2-auth.barnet.com.au (localhost [127.0.0.1]) by mail2.barnet.com.au (Postfix) with ESMTP id D2CB4B29D3A for ; Mon, 15 Mar 2004 23:50:25 +1100 (EST) Received: from k7.mavetju (edwin.adsl.barnet.com.au [203.111.122.2]) by mail2-auth.barnet.com.au (Postfix) with ESMTP id 09F8C19314 for ; Mon, 15 Mar 2004 23:50:24 +1100 (EST) Received: by k7.mavetju (Postfix, from userid 1001) id 7714C619E; Mon, 15 Mar 2004 23:50:24 +1100 (EST) Message-Id: <20040315125024.7714C619E@k7.mavetju> Date: Mon, 15 Mar 2004 23:50:24 +1100 (EST) From: Edwin Groothuis To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/64293: [patch] unbreak devel/ruby-rudl X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Edwin Groothuis List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2004 13:00:15 -0000 >Number: 64293 >Category: ports >Synopsis: [patch] unbreak devel/ruby-rudl >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Mar 15 05:00:14 PST 2004 >Closed-Date: >Last-Modified: >Originator: Edwin Groothuis >Release: FreeBSD 5.2.1-RELEASE i386 >Organization: - >Environment: System: FreeBSD k7.mavetju 5.2.1-RELEASE FreeBSD 5.2.1-RELEASE #3: Fri Feb 27 13:54:29 EST 2004 edwin@k7.mavetju:/usr/src/sys/i386/compile/k7 i386 >Description: See bento and friends: http://portsmon.firepipe.net/portoverview.py?category=&portname=ruby-rudl To make a long story short: the $CFLAGS in the extconf.rb needs an extra space before adding the -Wall to it. Also, when checking for SDL, check for SDL-1.1 >How-To-Repeat: >Fix: Either use this file as files/patch-extconf.rb: --- extconf.rb.orig Wed May 16 03:55:22 2001 +++ extconf.rb Mon Mar 15 23:43:45 2004 @@ -8,7 +8,7 @@ windows=/mswin32|cygwin/ =~ RUBY_PLATFORM -$CFLAGS+="-Wall " +$CFLAGS+=" -Wall " if !windows then $CFLAGS += `#{sdl_config} --cflags`.chomp @@ -24,8 +24,8 @@ have_header('SDL_image.h') have_header('SDL_mixer.h') -if have_library('SDL', 'SDL_Quit') and - have_library('SDLmain') and +if have_library('SDL-1.1', 'SDL_Quit') and + have_library('SDLmain-1.1') and have_header('SDL.h') then create_makefile('RUDL') or this patch which is hard to understand what is going on in. Index: files/patch-extconf.rb =================================================================== RCS file: /home/pcvs/ports/devel/ruby-rudl/files/patch-extconf.rb,v retrieving revision 1.3 diff -u -r1.3 patch-extconf.rb --- files/patch-extconf.rb 15 May 2001 19:01:19 -0000 1.3 +++ files/patch-extconf.rb 15 Mar 2004 12:45:36 -0000 @@ -1,14 +1,22 @@ ---- extconf.rb.orig Wed May 16 02:55:22 2001 -+++ extconf.rb Wed May 16 03:51:59 2001 -@@ -24,9 +24,7 @@ +--- extconf.rb.orig Wed May 16 03:55:22 2001 ++++ extconf.rb Mon Mar 15 23:43:45 2004 +@@ -8,7 +8,7 @@ + + windows=/mswin32|cygwin/ =~ RUBY_PLATFORM + +-$CFLAGS+="-Wall " ++$CFLAGS+=" -Wall " + + if !windows then + $CFLAGS += `#{sdl_config} --cflags`.chomp +@@ -24,8 +24,8 @@ have_header('SDL_image.h') have_header('SDL_mixer.h') -if have_library('SDL', 'SDL_Quit') and - have_library('SDLmain') and -- have_header('SDL.h') then -- -+if have_func('SDL_Quit') and -+ have_header('SDL.h') then ++if have_library('SDL-1.1', 'SDL_Quit') and ++ have_library('SDLmain-1.1') and + have_header('SDL.h') then + create_makefile('RUDL') - end >Release-Note: >Audit-Trail: >Unformatted: