From nobody Mon Apr 24 15:34:27 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q4q1c0c8Pz46ydZ for ; Mon, 24 Apr 2023 15:34:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q4q1b6bWQz3vdh for ; Mon, 24 Apr 2023 15:34:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682350467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KRqgm4UdeYxYR0uDhaBTSwmltREYN1HUyiEahxcJ7gw=; b=E+rE7D/88YZ67ufH1i6BTDStJK7EZNlY6aRN4FdauCBvZ1UbVRGhi7BWHTNWLLe5dOa3mw dmL2DNwLjWvs0gFuwj1gYgbvzeBKZKRptanwmmxvfPIClkRUpCrHuX1ELyEIUOgFMFTDtj ccT0PG58ctuqRuVHf7AhBMxXrTWMNz+OcaKkXgrkONtsPvmRO78uvIpr3+xAI5T6+33Kj0 KsaRJjYLTWlnK8YiUHWGgRXOpZ7BJuVLP4StSuZiQg0S+IqBV8pY+A30N9WofYBjfZNwma jxihQFSgtEY3+e1FeYKarxlm0775PLAgFenXZ8FnuJn5b7mKOARWnnT9ovBZoQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682350467; a=rsa-sha256; cv=none; b=Q9KLsvAqbuBdjw+AqpgoFS7UoDBaTkFGw9JUg2LzSDtI1ZgVGv94kBkqGjFDyE/oc9OP+B aRh61G+T2H8cWLO7U7EWr+GiZF4Qi7LFfLC448GbTUTRORoODJ/sG5ZFkifkjx0X7xaMyo 8UIhuvkqmpY8btXPCBSxTIXc6a9LRDeFE6VB427J1JTQqHtWsjnJ1HPhAX3GrU8/NeD1U7 29qFk3kWKu8IzdaFm1O9EjnDLRHO9qyz97cUIGY69SydOGuzpAMp27Qa9o67Y7DgTHEmYg wM2ODX4PuyHV33VEdC5etHSWRcOPfF4UPLaS93JwBuRyGKgwROi2fHJlg3RkNA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q4q1b5g07zWQ2 for ; Mon, 24 Apr 2023 15:34:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 33OFYR19051338 for ; Mon, 24 Apr 2023 15:34:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 33OFYRfG051337 for ports-bugs@FreeBSD.org; Mon, 24 Apr 2023 15:34:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 270989] print/ghostscript10: adds libgs.so; connects to USES and DEFAULT_VERSIONS facilities; flavorized Date: Mon, 24 Apr 2023 15:34:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: michael.osipov@siemens.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270989 --- Comment #4 from Michael Osipov --- Went through most of the patch, although it mostly looks fine, the patch do= es way too much from my S/W dev PoV, seperate concerns need to be addressed separately: 1. Add dynamic linking 2. Flavorize port 3. Clean up ghostscript.mk, everything before 9 should be removed 4. Clean up ports not to use a specific version directly: > ./graphics/graphviz/Makefile:GHOSTSCRIPT_LIB_DEPENDS=3D libgs.so:print/= ${_GS_PORT} Uses an implementation detail which is not acceptable, should be "USES=3Dghostscript" > ./graphics/inkscape/Makefile: ps2pdf:print/ghostscript9-agpl-ba= se \ "USES=3Dghostscript:run" > ./graphics/xfig/Makefile:LIB_DEPENDS=3D libgs.so:print/ghostscript9-agp= l-base \ "USES=3Dghostscript" 5. Adapt patch on top of cleaned up ghostscript.mk to integrate flavors of = 10 AND request an exp-run for 10 to see whether there are fallouts just to make sure. So this makes five patches here which gives us much more control of this important change. @dizzy Do you want me or Chad provide patch for 4 or do you want me to do t= his yourself? I will go on with these based on Chad's patch. --=20 You are receiving this mail because: You are the assignee for the bug.=