Date: Mon, 24 Apr 2023 15:34:27 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 270989] print/ghostscript10: adds libgs.so; connects to USES and DEFAULT_VERSIONS facilities; flavorized Message-ID: <bug-270989-7788-osu1w1iOVQ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-270989-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-270989-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270989 --- Comment #4 from Michael Osipov <michael.osipov@siemens.com> --- Went through most of the patch, although it mostly looks fine, the patch do= es way too much from my S/W dev PoV, seperate concerns need to be addressed separately: 1. Add dynamic linking 2. Flavorize port 3. Clean up ghostscript.mk, everything before 9 should be removed 4. Clean up ports not to use a specific version directly: > ./graphics/graphviz/Makefile:GHOSTSCRIPT_LIB_DEPENDS=3D libgs.so:print/= ${_GS_PORT} Uses an implementation detail which is not acceptable, should be "USES=3Dghostscript" > ./graphics/inkscape/Makefile: ps2pdf:print/ghostscript9-agpl-ba= se \ "USES=3Dghostscript:run" > ./graphics/xfig/Makefile:LIB_DEPENDS=3D libgs.so:print/ghostscript9-agp= l-base \ "USES=3Dghostscript" 5. Adapt patch on top of cleaned up ghostscript.mk to integrate flavors of = 10 AND request an exp-run for 10 to see whether there are fallouts just to make sure. So this makes five patches here which gives us much more control of this important change. @dizzy Do you want me or Chad provide patch for 4 or do you want me to do t= his yourself? I will go on with these based on Chad's patch. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-270989-7788-osu1w1iOVQ>