From owner-cvs-all Tue May 4 8: 7: 8 1999 Delivered-To: cvs-all@freebsd.org Received: from fleming.cs.strath.ac.uk (fleming.cs.strath.ac.uk [130.159.196.126]) by hub.freebsd.org (Postfix) with ESMTP id 3AF38150C7; Tue, 4 May 1999 08:06:57 -0700 (PDT) (envelope-from roger@cs.strath.ac.uk) Received: from cs.strath.ac.uk (scary.dmem.strath.ac.uk [130.159.202.5]) by fleming.cs.strath.ac.uk (8.8.8/8.8.8) with ESMTP id QAA17478 Tue, 4 May 1999 16:06:03 +0100 (BST) Message-ID: <372F0CE5.DB90A445@cs.strath.ac.uk> Date: Tue, 04 May 1999 16:06:13 +0100 From: Roger Hardiman Organization: Strathclyde University X-Mailer: Mozilla 4.04 [en] (X11; I; FreeBSD 3.1-STABLE i386) MIME-Version: 1.0 To: Mark Murray Cc: Roger Hardiman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, jkh@zippy.cdrom.com Subject: Re: cvs commit: src/sys/pccard pcic.c References: <199905041058.DAA25706@freefall.freebsd.org> <199905041254.OAA12457@greenpeace.grondar.za> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Mark, Jordan > It this adding functionality to 3.x brefore 4.x? If so, it should not be... No need to worry. I should have written a change log like this:- "Add extra sanity checking to prevent kernel panics with SMP kernels" The change is a bug fix. SMP kernels currently panic if they contain the pccard driver due to a problem in the pccard probe code. The change prevents the panic occuring. Back in December I found the problem and solved it with a 1 line fix (7 if you include the #ifdefs and #include lines) I posted it to -mobile and put it on my FTP site. I should have raised a PR. Oops. I then improved the patch and committed it to 4.x-current. Bruce then pointed out all the places the 'improved' patch was broken. I would fix -current now, but Warner is currently fix it for the newbus, so there is little point until he is finished. But after talking to Bruce, I decided to go back to the simple patch for the 3.x commit. Bye Roger -- Roger Hardiman Strathclyde Uni Telepresence Research Group, Glasgow, Scotland. http://telepresence.dmem.strath.ac.uk 0141 548 2897 roger@cs.strath.ac.uk To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message