Date: Tue, 10 Oct 2000 01:50:57 -0700 From: Jeremy Lea <reg@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: ports@FreeBSD.org, asami@FreeBSD.org Subject: Re: Problems with bsd.gnome.mk [patch] Message-ID: <20001010015057.O30468@shale.csir.co.za> In-Reply-To: <39E2C818.59B1E871@FreeBSD.org>; from sobomax@FreeBSD.org on Tue, Oct 10, 2000 at 10:41:13AM %2B0300 References: <39E184FE.7FCE1E41@FreeBSD.org> <20001009094132.H30468@shale.csir.co.za> <39E2AFE2.EF3DE9D0@FreeBSD.org> <39E2C818.59B1E871@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
On Tue, Oct 10, 2000 at 10:41:13AM +0300, Maxim Sobolev wrote:
> I do not see any benefits of this setup for ports with only optional
> GNOME support. In additional to my previous example with sawfish
> themes, for example xmms - it's in GNOME case only installs small
> applet, and IMHO it's not necessary to move the whole share/xmms into
> share/gnome. It's definitely not worth in this case to pollute
> pkg-plist with %%DATADIR%%, which creates additional headache in the
> case when you have to upgrade the port.
Please try this patch. You should be able to override datadir from the
port's Makefile.
e.g.:
CONFIGURE_ARGS= --datadir=${PREFIX}/share
-Jeremy
--
FreeBSD - Because the best things in life are free...
http://www.freebsd.org/
Index: bsd.gnome.mk
===================================================================
RCS file: /usr/home/ncvs/ports/Mk/bsd.gnome.mk,v
retrieving revision 1.3
diff -u -r1.3 bsd.gnome.mk
--- bsd.gnome.mk 2000/10/09 16:56:43 1.3
+++ bsd.gnome.mk 2000/10/10 08:48:14
@@ -253,9 +253,15 @@
.endif
.if defined(USE_GNOMELIBS)
-CONFIGURE_ARGS+=--localstatedir=${PREFIX}/share/gnome \
- --datadir=${PREFIX}/share/gnome \
- --with-gnome=${PREFIX}
+.if defined(HAVE_GNOME) && \
+ (${CONFIGURE_ARGS:S/localstatedir//} != ${CONFIGURE_ARGS})
+CONFIGURE_ARGS+=--localstatedir=${PREFIX}/share/gnome
+.endif
+.if defined(HAVE_GNOME) && \
+ (${CONFIGURE_ARGS:S/datadir//} != ${CONFIGURE_ARGS})
+CONFIGURE_ARGS+=--datadir=${PREFIX}/share/gnome \
+.endif
+CONFIGURE_ARGS+=--with-gnome=${PREFIX}
LIB_DEPENDS+= gnome.4:${PORTSDIR}/x11/gnomelibs
GNOME_CONFIG?= ${X11BASE}/bin/gnome-config
CONFIGURE_ENV+= GNOME_CONFIG="${GNOME_CONFIG}"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001010015057.O30468>