From owner-cvs-all@FreeBSD.ORG Sun Oct 12 01:23:54 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1005216A4BF for ; Sun, 12 Oct 2003 01:23:54 -0700 (PDT) Received: from mail.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1852743F93 for ; Sun, 12 Oct 2003 01:23:51 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 16097 invoked from network); 12 Oct 2003 08:23:50 -0000 Received: from unknown (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 12 Oct 2003 08:23:50 -0000 Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.9/8.11.6) id h9C8DNcW050997; Sun, 12 Oct 2003 01:13:23 -0700 (PDT) (envelope-from jmg) Date: Sun, 12 Oct 2003 01:13:23 -0700 From: John-Mark Gurney To: Poul-Henning Kamp Message-ID: <20031012081323.GL533@funkthat.com> References: <200310120706.h9C763U6085132@repoman.freebsd.org> <14061.1065945903@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14061.1065945903@critter.freebsd.dk> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sys_pipe.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Oct 2003 08:23:54 -0000 Poul-Henning Kamp wrote this message on Sun, Oct 12, 2003 at 10:05 +0200: > In message <200310120706.h9C763U6085132@repoman.freebsd.org>, John-Mark Gurney > writes: > >jmg 2003/10/12 00:06:03 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/kern sys_pipe.c > > Log: > > fix a problem referencing free'd memory. This is only a problem for > > kqueue write events on a socket and you regularly create tons of pipes > > which overwrites the structure causing a panic when removing the knote > > from the list. If the peer has gone away (and it's a write knote), then > > don't bother trying to remove the knote from the list. > > Does this fix make(1) compiled with -DUSE_KQUEUE ? Hmmm.. After looking at the make source, no, it probably doesn't. The bug this fixed was limited to EVFILT_WRITE events being registered on pipes, and make(1) doesn't use EVFILT_WRITE. Do we have a back trace on the problem with make? (I couldn't find a PR on it.) -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."