From owner-freebsd-ports@FreeBSD.ORG Tue Apr 2 17:51:43 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B05B6EE6 for ; Tue, 2 Apr 2013 17:51:43 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by mx1.freebsd.org (Postfix) with ESMTP id 368B7396 for ; Tue, 2 Apr 2013 17:51:43 +0000 (UTC) Received: from mailout-de.gmx.net ([10.1.76.1]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MC6kY-1UVv3e0Gn2-008sCq for ; Tue, 02 Apr 2013 19:51:42 +0200 Received: (qmail invoked by alias); 02 Apr 2013 17:51:41 -0000 Received: from p578be941.dip0.t-ipconnect.de (EHLO [192.168.0.100]) [87.139.233.65] by mail.gmx.net (mp001) with SMTP; 02 Apr 2013 19:51:41 +0200 X-Authenticated: #1956535 X-Provags-ID: V01U2FsdGVkX19+Ap9LMBB+muwC6gYFjHUtDrw8jEUMtfUgWwzAj5 AAGd3tthcD21qs Message-ID: <515B1AAD.4040705@gmx.de> Date: Tue, 02 Apr 2013 19:51:41 +0200 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: freebsd-ports@freebsd.org Subject: Re: [kde-freebsd] py27-pykde4-4.10.1 References: <1505116.DpgL6T9iEl@luna.wi.rr.com> <32500258.pAeBF4kCRX@indiana.smith> <20130402170814.GL56166@ithaqua.etoilebsd.net> <12878738.sI6p4J2xBi@indiana.smith> <20130402172440.GM56166@ithaqua.etoilebsd.net> In-Reply-To: <20130402172440.GM56166@ithaqua.etoilebsd.net> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Cc: Alberto Villa , Koop Mast , Baptiste Daroussin , kde-freebsd@kde.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2013 17:51:43 -0000 On 2013-04-02 19:24, Baptiste Daroussin wrote: > On Tue, Apr 02, 2013 at 07:14:36PM +0200, Alberto Villa wrote: >> On Tuesday 02 April 2013 19:08:14 Baptiste Daroussin wrote: >>> OPTIONSFILE is built base on UNIQUENAME which is built which uses >>> PKGNAMEPREFIX. >>> >>> that is the reason. >> >> bsd.options.mk, line 194: the .if exists(${OPTIONSFILE}) tries to evaluate >> (make(1) functions evaluate immediately, as you know), among other, >> PKGNAMEPREFIX, which is not yet set because bsd.python.mk is included at line >> 1424, while bsd.options.mk is included at line 1311 (speaking of bsd.port.mk). >> Thus, OPTIONSFILE is not included. >> This was the case with bsd.qt.mk, at least, so I suspect it's the same. > > Yes that true, and it is because OPTIONSFILE was (before optionsng) and still is > (with optionsng) built based on UNIQUENAME which is built base on PKGNAMEPREFIX. > cf bsd.port.mk L1286 > > So bsd.python.mk (it is not the only one) setting PKGNAMEPREFIX makes UNIQUENAME > not unique at all, first problem, it also make it changing meanng OPTIONSFILE > is expanded a first time to load options when PKGNAMEPREFIX is not yet set and > expanded a second time (when saving options) and PKGNAMEPREFIX is now set. > > bsd.options.mk can't anyway be loaded after bsd.port.pre.mk given that one may > want to provide a PYTHON option and will make it set USE_PYTHON=yes for > example. > > I don't know the right fix to be honnest. But UNIQUENAME not being UNIQUE is a > real problem imho and OPTIONSFILE changing depending on being after pre.mk or > before pre.mk is another problem. > > I don't know what came first between the bsd.*.mk changing the PKGNAMEPREFIX and > UNIQUENAME creation, but for sure one choice here hasn't been smart. > Havent't done a test and looked for the right place but maybe it's an option to chop prefixes like py2x, ap2x from OPTIONSFILE sample OPTIONSFILE=${PKGNAMEPREFIX:S/py27-//:S/ap22-//:S/ap24-// ... At last we should stop rewriting p5/py/ap ports to use only PORTDOCS / EXAMPLES to the new options style until we have a proof solution. -- Regards, olli