Date: Fri, 3 Jan 2020 22:37:50 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Adriaan de Groot <adridg@freebsd.org> Cc: Devin Teske <dteske@freebsd.org>, Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r521892 - in head/math: . R-cran-alabama Message-ID: <20200103213750.tmv6jujvx2tke5un@atuin.in.mat.cc> In-Reply-To: <2968169.bT80LyP3VS@beastie.bionicmutton.org> References: <202001030056.0030umrE001847@repo.freebsd.org> <20200103083628.b7b2b46pea33vu5f@atuin.in.mat.cc> <2968169.bT80LyP3VS@beastie.bionicmutton.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--tm42b5irv6lisgmo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 03, 2020 at 03:50:06PM +0100, Adriaan de Groot wrote: > On Friday, 3 January 2020 09:36:28 CET Mathieu Arnold wrote: > > On Fri, Jan 03, 2020 at 12:56:48AM +0000, Devin Teske wrote: > > > Author: dteske (src committer) > >=20 > > As stated by this ^^^^^^^^^^^^^ you are not a ports committer. So you > > are required to get approval, and state the approval in your commits, > > saying it has been reviewed is not enough. > >=20 > > > Reviewed by: mat, imp (previous revision) > > > Differential Revision: https://reviews.freebsd.org/D22675 >=20 > Question for mat@, just to be clear: the issue here is (only) that there= =20 > should be an extra line in the commit message, > Approved by: mat > or possibly > Approved by: mat (mentor) > as described in the committer's guide [1]. Yes, it was missing the approved by line. (Without the mentor part, dteske is not a ports committer.) > The Phab review was approved (accepted), so it's just the documentation o= f=20 > process?=20 >=20 >=20 > [1] https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ > commit-log-message.html >=20 >=20 > [ade] --=20 Mathieu Arnold --tm42b5irv6lisgmo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl4PtC5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkjsOhAAndofmmCHiPx6xZcWVonyYp0bmZGuZ0PcPGqY0kUkviHaAOVd2eEyFS/5 jBaz6OzeZRmSMWmxFKjbivtqmdPPtTLGzLRP0+cfHtLn/Kv12mnpa5zLAqa3UQfM kq++U72PhMNEwf72imxeomK6x8S1SMO6bjtrwQLyubERw6CVTqt1ium+NXovEg6f XpP2ay1ghGUIGlC3UzTP5HYWgbJS7hE3xU0mvvaz8UauT7bDoLUNUyE2WoeOIrSN cgEqR3sOEu3RQgs50qXDqxP+gH3uOpfMqY1NWPvhIOPnz5YHoi7CIY1nUVnCxqcP 039DDN+9PBoYv1+zWLCcnI7Ef3xX6G4QcoX6stjICJUhRCUljXw1wwqOJ6IfA6rU y0OW/fVtwik7LphYjGzFOPWUH8t6tFXrbihtqiB0oirRhdUzfxre0EpdXK6TJdDh kbrdzHYYqQdf0XH0ZA2mWZYxxtQseWFa6XIC/yUMSU49vpksczNiqB7WUU3POvQg 2tHikUO4i1KRlTuybm282m8/Ufo+3j+qG8MP5IFTBHWvxzo4EwbmElkqJqJfzHvH Dp8IESm+kSUhYNk4Z8HtaEcV72UTHvlgcX04HoZJaQQaw/n8+1zi0S7FoN5nZ+ag oD/ZBbuw0c8l4IoIGpUWAz7UTUp3wvU+Cgovd+brtjX7qo22Bfc= =/i7k -----END PGP SIGNATURE----- --tm42b5irv6lisgmo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200103213750.tmv6jujvx2tke5un>