Date: Fri, 2 Mar 2012 15:22:22 +0000
From: Chris Rees <utisoft@gmail.com>
To: Wesley Shields <wxs@freebsd.org>
Cc: Matthew Seaman <matthew@freebsd.org>, freebsd-ports <freebsd-ports@freebsd.org>
Subject: Re: On the usage of ${FILE}
Message-ID: <CADLo838yGkkX%2BTj68wmTghRUEu788ZFgynzoDGB=CdvBeeHEdg@mail.gmail.com>
In-Reply-To: <20120302131903.GE55531@atarininja.org>
References: <4F4F5C76.8040908@FreeBSD.org> <CADLo83-9TZWG9C7N0169HxxRJtPgAAvcYhA2UXQ2GpSNxGHkHw@mail.gmail.com> <20120302131903.GE55531@atarininja.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2 Mar 2012 13:19, "Wesley Shields" <wxs@freebsd.org> wrote:
>
> On Thu, Mar 01, 2012 at 12:38:01PM +0000, Chris Rees wrote:
> > On 1 Mar 2012 11:26, "Matthew Seaman" <matthew@freebsd.org> wrote:
> > >
> > >
> > > Dear all,
> > >
> > > bsd.commands.mk has the following:
> > >
> > > FILE?= /usr/bin/file
> > >
> > > which is unfortunate, given that ${FILE} is used in several thousand
> > > ports, generally as a loop control variable for iterating through a
list
> > > of files. In fact, I can only find about 8 places where the file(1)
> > > program is intended.
> > >
> > > This obvious conflict of meanings seems pretty undesirable to me. Am
I
> > > missing something? Is there any reason to keep the status quo rather
> > > than changing the bsd.commands.mk variable to FILE_CMD and making the
> > > corresponding changes in those 8 places?
> > >
> > > Cheers,
> > >
> > > Matthew
> > >
> >
> > I think that the loop control variables should be renamed to lower case.
>
> Except more of them in uppercase are bound to be added in the future,
> despite the best warnings not to do so.
Can I say portlint? ;)
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo838yGkkX%2BTj68wmTghRUEu788ZFgynzoDGB=CdvBeeHEdg>