From owner-cvs-src@FreeBSD.ORG Wed Oct 6 02:06:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B0EB16A4CE; Wed, 6 Oct 2004 02:06:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F1EB43D4C; Wed, 6 Oct 2004 02:06:11 +0000 (GMT) (envelope-from grog@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9626B4X098240; Wed, 6 Oct 2004 02:06:11 GMT (envelope-from grog@repoman.freebsd.org) Received: (from grog@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9626BM1098239; Wed, 6 Oct 2004 02:06:11 GMT (envelope-from grog) Message-Id: <200410060206.i9626BM1098239@repoman.freebsd.org> From: Greg Lehey Date: Wed, 6 Oct 2004 02:06:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2004 02:06:11 -0000 grog 2004-10-06 02:06:11 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c Log: getnewvnode: Weaken the panic "cleaned vnode isn't" to a warning. Discussion: this panic (or waning) only occurs when the kernel is compiled with INVARIANTS. Otherwise the problem (which means that the vp->v_data field isn't NULL, and represents a coding error and possibly a memory leak) is silently ignored by setting it to NULL later on. Panicking here isn't very helpful: by this time, we can only find the symptoms. The panic occurs long after the reason for "not cleaning" has been forgotten; in the case in point, it was the result of severe file system corruption which left the v_type field set to VBAD. That issue will be addressed by a separate commit. Revision Changes Path 1.529 +3 -1 src/sys/kern/vfs_subr.c