Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Oct 1999 19:37:41 -0700 (PDT)
From:      Cy.Schubert@uumail.gov.bc.ca
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/14316: fix to various exmh2 problems
Message-ID:  <199910140237.TAA07611@cwsys.cwsent.com>

next in thread | raw e-mail | index | archive | help

>Number:         14316
>Category:       ports
>Synopsis:       exmh not recognizing mh and uses too many colours
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 13 19:40:01 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Cy Schubert
>Release:        FreeBSD 3.3-RELEASE i386
>Organization:
ITSD Province of BC
>Environment:

FreeBSD cwsys 3.3-RELEASE FreeBSD 3.3-RELEASE #0: Wed Oct 13 08:09:56 PDT 1999     root@cwsys:/opt2/cvs-330/src/sys/compile/CWSYS  i386

>Description:

The enclosed patches to the exmh2 port fix the following problems.

1.  Exmh2 does not detect MH 6.8.4

2.  Exmh2 icon uses too many colours on an 8 bit display.

Reasons:

I use exmh2 with MH 6.8.4.

I use exmh2 on three FreeBSD systems, two with 16 bit displays and one
with an 8 bit display.  The colour icon uses too many colours causing
other apps to display in black & white.

A copy of this PR has been sent to the maintainer of Exmh, welch@acm.org,
and hopefully he'll incorporate these patches into the base product.
Until then, might it be possible to include these patches?

>How-To-Repeat:

Use exmh2 on a system with MH 6.8.4 installed.

Use exmh2 on an 8 bit display.

>Fix:
	
The following patch properly detects if MH 6.8.4 is installed.  It
also detects whether an X server is using an 8 bit or 16 bit (or higer)
display.

diff -urPN /opt/CVSup/usr/ports/mail/exmh2/patches/patch-ca exmh2-991013/patches/patch-ca
--- /opt/CVSup/usr/ports/mail/exmh2/patches/patch-ca	Wed Dec 31 16:00:00 1969
+++ exmh2-991013/patches/patch-ca	Wed Oct 13 19:15:51 1999
@@ -0,0 +1,11 @@
+--- lib/main.tcl.orig	Wed Oct 13 06:55:20 1999
++++ lib/main.tcl	Wed Oct 13 07:39:23 1999
+@@ -14,7 +14,7 @@
+ proc Exmh {} {
+     global exmh argv nmh
+ 
+-    if ![ catch {string match *-group* [exec repl -help] } ] {
++    if [ string match *-group* [exec repl -help] ] {
+ 	set nmh 1
+     } else {
+ 	set nmh 0
diff -urPN /opt/CVSup/usr/ports/mail/exmh2/patches/patch-cb exmh2-991013/patches/patch-cb
--- /opt/CVSup/usr/ports/mail/exmh2/patches/patch-cb	Wed Dec 31 16:00:00 1969
+++ exmh2-991013/patches/patch-cb	Wed Oct 13 19:16:32 1999
@@ -0,0 +1,22 @@
+--- lib/main.tcl.ORIG	Wed Oct 13 07:39:23 1999
++++ lib/main.tcl	Wed Oct 13 17:56:01 1999
+@@ -12,12 +12,18 @@
+ # any specification.
+ 
+ proc Exmh {} {
+-    global exmh argv nmh
++    global exmh argv nmh planes
+ 
+     if [ string match *-group* [exec repl -help] ] {
+ 	set nmh 1
+     } else {
+ 	set nmh 0
++    }
++
++    if [ string match *depth\ of\ root\ window:\ \ \ \ 8\ planes* [exec xdpyinfo] ] {
++	set planes 8
++    } else {
++	set planes 0
+     }
+ 
+     Mh_Init		;# Defines mhProfile
diff -urPN /opt/CVSup/usr/ports/mail/exmh2/patches/patch-cc exmh2-991013/patches/patch-cc
--- /opt/CVSup/usr/ports/mail/exmh2/patches/patch-cc	Wed Dec 31 16:00:00 1969
+++ exmh2-991013/patches/patch-cc	Wed Oct 13 18:09:37 1999
@@ -0,0 +1,20 @@
+--- lib/flag.tcl.orig	Wed Oct 13 06:55:20 1999
++++ lib/flag.tcl	Wed Oct 13 17:57:21 1999
+@@ -24,7 +24,7 @@
+ # any specification.
+ 
+ proc Flag_Init {} {
+-    global flag exmh
++    global flag exmh planes
+     set flag(state) init
+     
+     # Note - if you change the icon, there is some code in ExmhArgv
+@@ -50,7 +50,7 @@
+ 	    set flag($i) 0
+ 	}
+     }
+-    if {!$exmh(slowDisp) || $exmh(slowDispIcons)} {
++    if {(!$exmh(slowDisp) || $exmh(slowDispIcons)) && $planes != 8} {
+ 	if [catch {
+ 	    Exmh_Debug "Creating .icon"
+ 	    toplevel .icon

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199910140237.TAA07611>