Date: Mon, 13 Aug 2012 15:52:08 -0700 From: David O'Brien <obrien@FreeBSD.org> To: Beat Gaetzi <beat@FreeBSD.org> Cc: svn-doc-head@freebsd.org, svn-doc-all@freebsd.org, doc-committers@freebsd.org Subject: Re: svn commit: r39217 - head/en_US.ISO8859-1/articles/committers-guide Message-ID: <20120813225208.GA27852@dragon.NUXI.org> In-Reply-To: <201207151931.q6FJVcMm067877@svn.freebsd.org> References: <201207151931.q6FJVcMm067877@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 15, 2012 at 07:31:38PM +0000, Beat Gaetzi wrote: > - Add ports specific information to the Subversion primer ... > <para>Before adding files, get a copy of <ulink > url="http://people.freebsd.org/~peter/auto-props.txt">auto-props.txt</ulink>; > + (there is also a <ulink > + url="http://people.freebsd.org/~beat/cvs2svn/auto-props.txt">; > + ports tree specific version</ulink>) > and add it to <filename>~/.subversion/config</filename> Hi Beat, The subversion conversion seems to have gone very well. However, was http://people.freebsd.org/~beat/cvs2svn/auto-props.txt publicly reviewed? I don't understand why we want distinfo*, extrapatch-*, extra-patch-*, patch-*, pkg-* to have "fbsd:nokeywords=yes". patch(1) handles $FreeBSD$ in a patch file just fine -- 'emacs/files/patch-configure' is one example. Additionally, the pkg-plist file format has a comment so $FreeBSD$ is benign in those files and useful. It may make some sense to exclude the other pkg-* files from requiring $FreeBSD$. I don't see how the content of http://people.freebsd.org/~peter/auto-props.txt conflicts with the Ports Collection subversion repository. However http://people.freebsd.org/~beat/cvs2svn/auto-props.txt implies it is. If a port has a .c file committed, it should have a $FreeBSD$ e.g. 'audio/xcdplayer/files/cdrom_freebsd.c'. What I think we really need to do, is to commit http://people.freebsd.org/~peter/auto-props.txt somewhere where it can be maintained with version control. Maybe 'svn+ssh://svn.freebsd.org/base/svnadmin/conf' would be a good location. Then add the Ports Collection needed entries. Notably bsd.*.mk, distinfo*, extrapatch-*, extra-patch-*, patch-*, pkg-*. I think it is unreasonable to expect folks to use svn ____ --config-dir ~/.subversion-ports every time they use use subversion with the Ports Collection. thanks, -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120813225208.GA27852>