From owner-cvs-src@FreeBSD.ORG Tue Apr 8 12:54:04 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E15F737B401; Tue, 8 Apr 2003 12:54:04 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id EDDD743F3F; Tue, 8 Apr 2003 12:54:03 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h38JruZq024698; Tue, 8 Apr 2003 21:53:57 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: "Sam Leffler" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 08 Apr 2003 12:42:36 PDT." <074e01c2fe07$0205b5b0$52557f42@errno.com> Date: Tue, 08 Apr 2003 21:53:56 +0200 Message-ID: <24697.1049831636@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/adlink adlink.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Apr 2003 19:54:05 -0000 In message <074e01c2fe07$0205b5b0$52557f42@errno.com>, "Sam Leffler" writes: >> Use #ifdef _KERNEL to let .c file double as .h file defining the ioctls. > >Yech! If style(9) doesn't address this, I'd say it's time to add it. I'd say it's not. If you look at all the irrelevant crap we currently install in /usr/include/sys and surrounding areas, I think you should rather look at this as a way to avoid adding more junk to that pile. The very few userland programs which will interact with a device like the adlink, are not acting through a highly abstracted general API, they are acting in close concert with the hardware through the simplest and most targeted API possible. There is even a good probability that the kernel driver will be tweaked on a per installation basis to match local circumstances. In such cases it makes no sense to install a .h file in /usr/include/mumble, it makes a lot more sense to exploit the fact that we are an open-source project and point the two bits directly at each other to avoid any sort of confusion as to which bits are used and what level of generality is available. Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.