From owner-freebsd-bugs@FreeBSD.ORG Mon Aug 8 20:40:15 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 245FF16A41F for ; Mon, 8 Aug 2005 20:40:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A4A343D53 for ; Mon, 8 Aug 2005 20:40:14 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j78KeE0e082895 for ; Mon, 8 Aug 2005 20:40:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j78KeENf082892; Mon, 8 Aug 2005 20:40:14 GMT (envelope-from gnats) Resent-Date: Mon, 8 Aug 2005 20:40:14 GMT Resent-Message-Id: <200508082040.j78KeENf082892@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Antoine Pelisse Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7866616A41F for ; Mon, 8 Aug 2005 20:30:42 +0000 (GMT) (envelope-from willow@xloling.org) Received: from hellmuth.xloling.org (willow.xloling.org [82.67.83.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id CDD3B43D45 for ; Mon, 8 Aug 2005 20:30:41 +0000 (GMT) (envelope-from willow@xloling.org) Received: from hellmuth.xloling.org (localhost [127.0.0.1]) by hellmuth.xloling.org (8.13.4/8.13.4) with ESMTP id j78KUdKS006268 for ; Mon, 8 Aug 2005 22:30:39 +0200 (CEST) (envelope-from willow@xloling.org) Received: (from willow@localhost) by hellmuth.xloling.org (8.13.4/8.13.1/Submit) id j78KUcbR006263; Mon, 8 Aug 2005 22:30:38 +0200 (CEST) (envelope-from willow) Message-Id: <200508082030.j78KUcbR006263@hellmuth.xloling.org> Date: Mon, 8 Aug 2005 22:30:38 +0200 (CEST) From: Antoine Pelisse To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/84684: [PATCH] Kernel panic in kern_proc.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Antoine Pelisse List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2005 20:40:15 -0000 >Number: 84684 >Category: kern >Synopsis: [PATCH] Kernel panic in kern_proc.c >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Aug 08 20:40:13 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Antoine Pelisse >Release: FreeBSD 7.0-CURRENT i386 >Organization: Xloling >Environment: System: FreeBSD hellmuth.xloling.org 7.0-CURRENT FreeBSD 7.0-CURRENT #21: Mon Aug 8 15:06:49 CEST 2005 i386 >Description: Fix for kernel panics: http://people.freebsd.org/~pho/stress/log/cons149.html http://people.freebsd.org/~pho/stress/log/cons130.html >How-To-Repeat: >Fix: --- sys/kern/kern_proc.c.orig Mon Apr 18 04:10:36 2005 +++ sys/kern/kern_proc.c Mon Aug 8 22:00:27 2005 @@ -868,7 +868,7 @@ { struct thread *td; struct kinfo_proc kinfo_proc; - int error = 0; + int error, buffersize = 0; struct proc *np; pid_t pid = p->p_pid; @@ -883,11 +883,23 @@ } else { _PHOLD(p); FOREACH_THREAD_IN_PROC(p, td) { + buffersize += sizeof(struct kinfo_proc); + } + PROC_UNLOCK(p); + + buffersize += 5 * sizeof(struct kinfo_proc); + error = sysctl_wire_old_buffer(req, buffersize); + if (error) { + _PRELE(p); + return error; + } + + PROC_LOCK(p); + FOREACH_THREAD_IN_PROC(p, td) { fill_kinfo_thread(td, &kinfo_proc); - PROC_UNLOCK(p); error = SYSCTL_OUT(req, (caddr_t)&kinfo_proc, sizeof(kinfo_proc)); - PROC_LOCK(p); + if (error) break; } >Release-Note: >Audit-Trail: >Unformatted: