From nobody Tue Nov 11 12:08:21 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d5QKd56n7z6GLFX; Tue, 11 Nov 2025 12:08:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d5QKd20WHz3c28; Tue, 11 Nov 2025 12:08:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762862901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j9LVnXGhR4qSpGySL6NMY8qJgi7W0xVGMibwV8LxBdQ=; b=O5mZBwcOMr4fMLsm0XlkD++tQgzznBknBexRQ2MS9C3sJmaQuoTNzd/uNdH6n7Y2cEsiP7 N5E8kvQzGaBXjjTrJipKAy4bAaXiZBgvtLuYoZojK4oITgq5XgtXLBUxU0AXFvwZLALJxh INOe9vN+Eo7xbaNTLRuy3Qi9beKLvMa4re0cBduVPK9G0omIA6G9xctL3NanjZUC/mUF0k KmaSRTgz1n31uQg83Ru4wBXa/393wZJoYfmrEOlzBlUn9Ng+SVkh0rHgulG9iCKbxeAfqk HNDXxw2y5ZDyvqlobGj4EZxEaVU9uYpGZOGrxFioCQcUAxPOAIHubl025+f7NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762862901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j9LVnXGhR4qSpGySL6NMY8qJgi7W0xVGMibwV8LxBdQ=; b=kchjpf/NS/daxMj51KdJ4jBrG2BFN/dQTgr7qMBOVkYMbDr2qOPd/vuJQVQZEJVe9g1UiO ph/YBv2SZGNkEi2sz0U2schh5Ok7JqAdIIkF4hv2KwerAixL8RKGIxNGU2qTvUB9k2ANEt PVzDvfPdSOYXu/1xqiCvE/jMQgDuJOpEBy23TTV44xkOoElERZ9HF4KKSi66lqzP2MCq11 XvgI+nXuk/tBQV0J8zfXRCj85jXx65p6kI4X9BQ1IS/4HMCTp3sfNXQyhpMO7kQ6YzIg40 Tr5CXmM3R97yKO08UjkfPBQeWhZFvVdrHGJWPScx9drtCowCaCmBuTDw5+EdgQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762862901; a=rsa-sha256; cv=none; b=InxyRFXecCO6oduW5t7vWPGRx8C3p4NgChkJHBk8Ul/JJGFQhLYlHyXsgwTAqTDg66P9FH igxs7t1FI1LICqhOjyxfrDM55ZiAxFNeCMDPsVhvoJ8EcAADqK5wUilqKIlEiTaYA8c7Rp lcDwrADZE29JUZIXe95JlXdU7xDWgMeFvtFKHCV5RwK3uOw6mWL5OgshYq34F12btpyVtv iiHgH4TLz6QxkxTiaPkKTN+hC6yVLOJSm/UPEunFkVtMmWLp+3XXgRje3GXFf/UuvVF5+j iEXU/sYoRQutawbGNzLRhJjJW+dWQHZsgOaJ4jD86q0D0k4aUpKhmaYxY0gocQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d5QKd1Zrpz13Wv; Tue, 11 Nov 2025 12:08:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5ABC8LSL035442; Tue, 11 Nov 2025 12:08:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5ABC8Lie035439; Tue, 11 Nov 2025 12:08:21 GMT (envelope-from git) Date: Tue, 11 Nov 2025 12:08:21 GMT Message-Id: <202511111208.5ABC8Lie035439@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 699fd108c50c - main - sound: Remove unnecessary initializations in feeder_create() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 699fd108c50ccbd576476a2c95fa03e16492f2f9 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=699fd108c50ccbd576476a2c95fa03e16492f2f9 commit 699fd108c50ccbd576476a2c95fa03e16492f2f9 Author: Christos Margiolis AuthorDate: 2025-11-11 12:06:32 +0000 Commit: Christos Margiolis CommitDate: 2025-11-11 12:06:32 +0000 sound: Remove unnecessary initializations in feeder_create() We do not need to zero out fields since the struct is allocated with M_ZERO. Also we no longer need to have a special case for the root feeder. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D53558 --- sys/dev/sound/pcm/feeder.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/sys/dev/sound/pcm/feeder.c b/sys/dev/sound/pcm/feeder.c index 874148cd9ab0..75c0f0405040 100644 --- a/sys/dev/sound/pcm/feeder.c +++ b/sys/dev/sound/pcm/feeder.c @@ -88,19 +88,10 @@ feeder_create(struct feeder_class *fc, struct pcm_feederdesc *desc) if (f == NULL) return NULL; - f->data = NULL; - f->source = NULL; - f->parent = NULL; f->class = fc; f->desc = &(f->desc_static); - - if (desc) { + if (desc != NULL) *(f->desc) = *desc; - } else { - f->class->type = FEEDER_ROOT; - f->desc->in = 0; - f->desc->out = 0; - } err = FEEDER_INIT(f); if (err) {