From owner-svn-src-all@FreeBSD.ORG Mon Dec 1 15:39:06 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1C8EE9AF; Mon, 1 Dec 2014 15:39:06 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id B224EDEC; Mon, 1 Dec 2014 15:39:05 +0000 (UTC) Received: from [100.93.87.91] (184.sub-70-197-13.myvzw.com [70.197.13.184]) by elvis.mu.org (Postfix) with ESMTPSA id 85BC5341F84F; Mon, 1 Dec 2014 07:39:05 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r275136 - in head/sys: dev/e1000 dev/ixgbe kern sys From: Alfred Perlstein X-Mailer: iPhone Mail (12B436) In-Reply-To: <547C8A9C.4080603@selasky.org> Date: Mon, 1 Dec 2014 07:39:04 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201411262019.sAQKJaw4043557@svn.freebsd.org> <39377603.10OyiSzjWY@ralph.baldwin.cx> <872C180A-6ADD-469F-A801-3728DF134EEC@mu.org> <547C88A9.1070007@selasky.org> <5E1B6CD4-BBA7-4AD0-9982-E981015AF138@mu.org> <547C8A9C.4080603@selasky.org> To: Hans Petter Selasky Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Alfred Perlstein , "src-committers@freebsd.org" , John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Dec 2014 15:39:06 -0000 > On Dec 1, 2014, at 7:34 AM, Hans Petter Selasky wrote: >=20 >> On 12/01/14 16:29, Alfred Perlstein wrote: >>=20 >>=20 >>>> On Dec 1, 2014, at 7:26 AM, Hans Petter Selasky wrote= : >>>>=20 >>>> On 12/01/14 16:19, Alfred Perlstein wrote: >>>> It makes little sense to have a rw sysctl that only takes effect "some t= imes". This violates POLA at the expense of making code appear cleaner. Expe= ctation is that writable sysctls take >>>=20 >>> Hi, >>>=20 >>> I think you are missing a new feature in 11-current, that if you add "CT= LFLAG_TUN" to even dynamic sysctls, they get initialized from the enviroment= , if any. That way you can just skip the TUNABLE_INT_FETCH() stuff! >>=20 >> Ok I can probably switch to that. >>=20 >> Any objection if I mfc this feature to -stable if it does what I need? >=20 > Hi, >=20 > No objections from me at least, but it might require some work from your s= ide, because there was a lot of cleanup about removing duplicate definitions= , like static SYSCTLS which have already CTLFLAG_TUN and a TUNABLE fetch sta= tement, which makes the variable init twice. Just look at the revision histo= ry for "kern/kern_sysctl.c" in 11-current. >=20 > --HPS >=20 >=20 One question though... For the global sysctl for all nodes.... When is the var fetched? If it's before SI_SUB_CPU it is not useful. =20=