From owner-cvs-src-old@FreeBSD.ORG Fri Feb 6 17:14:20 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 16F5010657BD for ; Fri, 6 Feb 2009 17:14:20 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 045D38FC19 for ; Fri, 6 Feb 2009 17:14:20 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n16HEJuN098455 for ; Fri, 6 Feb 2009 17:14:19 GMT (envelope-from trasz@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n16HEJa2098454 for cvs-src-old@freebsd.org; Fri, 6 Feb 2009 17:14:19 GMT (envelope-from trasz@repoman.freebsd.org) Message-Id: <200902061714.n16HEJa2098454@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to trasz@repoman.freebsd.org using -f From: Edward Tomasz Napierala Date: Fri, 6 Feb 2009 17:14:07 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2009 17:14:20 -0000 trasz 2009-02-06 17:14:07 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_alloc.c Log: SVN rev 188240 on 2009-02-06 17:14:07Z by trasz When a device containing mounted UFS filesystem disappears, the type of devvp becomes VBAD, which UFS incorrectly interprets as snapshot vnode, which in turns causes panic. Fix it by replacing '!= VCHR' with '== VREG'. With this fix in place, you should no longer be able to panic the system by removing a device with an UFS filesystem mounted from it - assuming you don't use softupdates. Reviewed by: kib Tested by: pho Approved by: rwatson (mentor) Sponsored by: FreeBSD Foundation Revision Changes Path 1.152 +4 -4 src/sys/ufs/ffs/ffs_alloc.c