From owner-freebsd-net@FreeBSD.ORG  Thu Jan 30 15:18:29 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 71788CE6;
 Thu, 30 Jan 2014 15:18:29 +0000 (UTC)
Received: from mail-qc0-x234.google.com (mail-qc0-x234.google.com
 [IPv6:2607:f8b0:400d:c01::234])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 229411601;
 Thu, 30 Jan 2014 15:18:29 +0000 (UTC)
Received: by mail-qc0-f180.google.com with SMTP id i17so5178873qcy.11
 for <multiple recipients>; Thu, 30 Jan 2014 07:18:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:date:message-id:subject:from:to:content-type;
 bh=ugcUvCRSsoGpTtfZbv0Uhnr4LqgB0lzB/VnS6jy4UO4=;
 b=pl2xqtvo2xByrojDI07wxBJuZQHV3freN+XlfHzdCDo1GOHkZNAJmcJp6r5HxFwRSP
 QsgtoBoHFM4MO7AFvUphy2Cr13fRvOh2MppC44R/MXuyFvrg/bgsBhHTH54uzspd7I9v
 HUBiKAnhxtd3zb/R5wWY5kDANHHPzhEwFqYCOYbW59W1IkEUbct3EgAJHkfN/117P1yy
 rTwCJeeMIfDp6btQy50fjlgEeOhLbT6zCqGhpwXCec3rhciSEcUhYlCZ5wfQ41toOJTQ
 EsvhM0xOnsrJ/sVy9N64+ICFzbnmHEL/ggqevC8DKPdtHKFbutWHZhDu3t9gIuEX5q7k
 ttPQ==
MIME-Version: 1.0
X-Received: by 10.229.35.194 with SMTP id q2mr22669825qcd.7.1391095108227;
 Thu, 30 Jan 2014 07:18:28 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.224.52.8 with HTTP; Thu, 30 Jan 2014 07:18:28 -0800 (PST)
Date: Thu, 30 Jan 2014 07:18:28 -0800
X-Google-Sender-Auth: b7mz-_vmvNsP2ykU0q8_bR9XTA8
Message-ID: <CAJ-VmokSjj_7qCRL3juczq_XO8h9etOarsnasjfNg4upmkMX9Q@mail.gmail.com>
Subject: 
From: Adrian Chadd <adrian@freebsd.org>
To: FreeBSD Net <freebsd-net@freebsd.org>, 
 "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jan 2014 15:18:29 -0000

Hi,

I'd like to disable the code in flowtable.c that assigns the mbuf flowid.

I'd like to ensure that any mbuf flowid that's set is (eventually)
going to be consistently toeplitz in the future (to match what NICs
are doing on the RX side) and this may cause the flowid to be set to
something completely different.

I've only done some light production testing with this so far, to no
visible ill effects.

What do people think?

Thanks,


-a


Index: sys/net/flowtable.c
===================================================================
--- sys/net/flowtable.c (revision 261001)
+++ sys/net/flowtable.c (working copy)
@@ -1102,10 +1102,12 @@
  if (af == AF_INET6)
  fle = flowtable_lookup_mbuf6(ft, m);
 #endif
+#if 0
  if (fle != NULL && m != NULL && (m->m_flags & M_FLOWID) == 0) {
  m->m_flags |= M_FLOWID;
  m->m_pkthdr.flowid = fle->f_fhash;
  }
+#endif
  return (fle);
 }