Date: Fri, 3 Jan 2020 22:40:36 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Devin Teske <dteske@freebsd.org> Cc: Pedro Giffuni <pfg@FreeBSD.org>, Adriaan de Groot <adridg@freebsd.org>, Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r521892 - in head/math: . R-cran-alabama Message-ID: <20200103214036.u3mcrrsu6iso2jwn@atuin.in.mat.cc> In-Reply-To: <77DAB365-CC5A-40B3-B1C9-C9562C442833@freebsd.org> References: <202001030056.0030umrE001847@repo.freebsd.org> <20200103083628.b7b2b46pea33vu5f@atuin.in.mat.cc> <2968169.bT80LyP3VS@beastie.bionicmutton.org> <29C42407-97B1-4DDB-BEC3-DB397ECD85C7@freebsd.org> <6ba53399-84f5-961f-1fa1-1fb53f8f984f@FreeBSD.org> <77DAB365-CC5A-40B3-B1C9-C9562C442833@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--i6omdzkdh5lzd6gl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 03, 2020 at 12:02:31PM -0800, Devin Teske wrote: >=20 >=20 > > On Jan 3, 2020, at 11:17, Pedro Giffuni <pfg@FreeBSD.org> wrote: > >=20 > >=20 > > On 03/01/2020 13:01, Devin Teske wrote: > >>=20 > >>> On Jan 3, 2020, at 06:50, Adriaan de Groot <adridg@freebsd.org> wrote: > >>>=20 > >>> On Friday, 3 January 2020 09:36:28 CET Mathieu Arnold wrote: > >>>> On Fri, Jan 03, 2020 at 12:56:48AM +0000, Devin Teske wrote: > >>>>> Author: dteske (src committer) > >>>> As stated by this ^^^^^^^^^^^^^ you are not a ports committer. So y= ou > >>>> are required to get approval, and state the approval in your commits, > >>>> saying it has been reviewed is not enough. > >>>>=20 > >>>>> Reviewed by: mat, imp (previous revision) > >>>>> Differential Revision: https://reviews.freebsd.org/D22675 > >>> Question for mat@, just to be clear: the issue here is (only) that th= ere > >>> should be an extra line in the commit message, > >>> Approved by: mat > >>> or possibly > >>> Approved by: mat (mentor) > >>> as described in the committer's guide [1]. > >>>=20 > >>> The Phab review was approved (accepted), so it's just the documentati= on of > >>> process? > >>>=20 > >>>=20 > >>> [1] https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-g= uide/ > >>> commit-log-message.html > >>>=20 > >> The process is broken currently as I=E2=80=99ve been denied a ports co= mmit bit and my mentorship is null and void for a ports bit. > >>=20 > >> I do not not know how to navigate such a situation. > >>=20 > >> In this case, would review be akin to approval and thus, whomsoever re= viewed it that is an active ports committer is therefore the approver? > >=20 > > Active committers can commit to other parts of the tree if they get app= roval from other active committers in that branch. It works both ways: src = committers can (exceptionally) do ports or doc commits, and the other way a= round. However, a phabricator review is not an approval unless it is explic= it. > >=20 > > Just my $0.02, > >=20 >=20 > What explicitly constitutes apprroval then? It means that you can only commit whatever you got approval for. If you need to change something from what was approved, you need to get approval again. You cannot commit an "updated revision". --=20 Mathieu Arnold --i6omdzkdh5lzd6gl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl4PtNRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkjt4A/+J//q87itce2Jd4fzXSUrAZt4FCYyxl3VJXGpsmtiIgcXCvSbNlF4YQhM wg9yqas7LEllE92ggOpk6AaTYstJgKr4rI8fp30yEw8c24GQrMaMHV0PohU4jxem V2ZgYtHVbRHjcUkUzlTmTQJ9sbSl0YC1IW9u6j+RRHjXOVJXU8iy415wAJUtqCSZ MxoBJtG3vdJl7F5sNsfoHwnj9XfKQSzdXY2KEYwqHDQSSaSiLu/TfGgacOZaaCBt lKbUhhDjIWcz2Rq1mTHXqjyWWzAoS+Quy2DMcBRMCMh3EcqcRrbSdMfTEw4gYlug ZZrxCJXsAlpKVAM2o/3SdkuSa2uttp9utiPBf5nq5J6I7bZ8g45bhzpgQWRgHm4J YOJNdQ+wue/BTPrMLDm8ofQirOaU2S/T20hl8XEWZflakRnZBiUVyIMh++iziWFT e9aeqw07WYpOk2K+qVPCzUVFbDq9QKgGlyw8gnxTdchMM+BfExtMHkru3iPmXPMi HdJ3jAultEvBZ1crkwUiCSikRCprkIKTe82yK3ZUGpA0er1Z1yuPHLsrehtwsIdg OaFVh/XZgbkjQTpP96T9wpJlwJKJZx2qKMYhfqk2zNvXujRm52/UcGcut+fJCgXm fhGY+Pk+af9apTpGqLJQY5bvZ+uhqyGpa8jH8jn85bCHRI7EHJE= =GiLQ -----END PGP SIGNATURE----- --i6omdzkdh5lzd6gl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200103214036.u3mcrrsu6iso2jwn>