From owner-freebsd-current@FreeBSD.ORG  Wed Oct 22 21:06:21 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 0E1DF1065699;
	Wed, 22 Oct 2008 21:06:20 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: freebsd-current@FreeBSD.org
Date: Wed, 22 Oct 2008 17:06:05 -0400
User-Agent: KMail/1.6.2
References: <20081022204414.GR11652@bunrab.catwhisker.org>
	<200810221658.44832.jkim@FreeBSD.org>
	<200810221700.26253.jkim@FreeBSD.org>
In-Reply-To: <200810221700.26253.jkim@FreeBSD.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200810221706.10725.jkim@FreeBSD.org>
Cc: 
Subject: Re: Parenthesizing problem in sys/i386/i386/identcpu.c
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Oct 2008 21:06:21 -0000

On Wednesday 22 October 2008 05:00 pm, Jung-uk Kim wrote:
> On Wednesday 22 October 2008 04:58 pm, Jung-uk Kim wrote:
> > On Wednesday 22 October 2008 04:44 pm, David Wolfskill wrote:
> > > This was from around line 847; whine I saw was:
> > > >>> Kernel build for FREEBEAST started on Wed Oct 22 12:50:05
> > > >>> PDT 2008
> > >
> > > ...
> > >
> > > >>> stage 3.2: building everything
> > >
> > > ...
> > > cc -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls
> > > -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes
> > > -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign
> > > -fformat-extensions -nostdinc  -I. -I/usr/src/sys
> > > -I/usr/src/sys/contrib/altq -D_KERNEL
> > > -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common
> > > -finline-limit=8000 --param inline-unit-growth=100 --param
> > > large-function-growth=1000 -mno-align-long-strings
> > > -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse
> > > -mno-sse2 -mno-sse3 -ffreestanding
> > > -fstack-protector -Werror  /usr/src/sys/i386/i386/identcpu.c
> > > cc1: warnings being treated as errors
> > > /usr/src/sys/i386/i386/identcpu.c: In function 'printcpuinfo':
> > > /usr/src/sys/i386/i386/identcpu.c:847: warning: suggest
> > > parentheses around && within ||
> > > /usr/src/sys/i386/i386/identcpu.c:847: error: expected
> > > statement before ')' token *** Error code 1
> > >
> > > Stop in /common/S4/obj/usr/src/sys/FREEBEAST.
> > > *** Error code 1
> > >
> > > Stop in /usr/src.
> > > [End of excerpt...]
> > >
> > > The attached patch got me through the buildkernel, and the
> > > resulting kernel booted OK -- for me.  I'm only using the i386
> > > arch; I don't know if there might be similar issues for any
> > > other arch.
> > >
> > > It applied to rev. 1.190 of src/sys/i386/i386/identcpu.c.
> > > (Sorry; I'm still reading about Subversion, and haven't got my
> > > thinking converted yet.)
> >
> > It's already fixed on head:
> >
> > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/i386/i386/identcpu.
> >c. diff?r1=1.190;r2=1.192
> >
> > Sorry for the inconvenience,
>
> Doh, there is a copy-and-pasto!  Will fix soon.
>
> Today is not my day. :-(

Done:

http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/i386/i386/identcpu.c.diff?r1=1.190;r2=1.193>

Jung-uk Kim