From owner-freebsd-fs@FreeBSD.ORG Tue Dec 16 20:10:48 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 500471065674 for ; Tue, 16 Dec 2008 20:10:48 +0000 (UTC) (envelope-from rick@kiwi-computer.com) Received: from kiwi-computer.com (keira.kiwi-computer.com [63.224.10.3]) by mx1.freebsd.org (Postfix) with SMTP id DC1C48FC30 for ; Tue, 16 Dec 2008 20:10:47 +0000 (UTC) (envelope-from rick@kiwi-computer.com) Received: (qmail 34863 invoked by uid 2001); 16 Dec 2008 20:10:46 -0000 Date: Tue, 16 Dec 2008 14:10:46 -0600 From: "Rick C. Petty" To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Message-ID: <20081216201046.GA34809@keira.kiwi-computer.com> References: <20081213173902.GA96883@keira.kiwi-computer.com> <20081213183058.GA20992@a91-153-125-115.elisa-laajakaista.fi> <20081213192320.GA97766@keira.kiwi-computer.com> <86y6yh5pz0.fsf@ds4.des.no> <20081215234809.GA24403@keira.kiwi-computer.com> <8663lk5ju7.fsf@ds4.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8663lk5ju7.fsf@ds4.des.no> User-Agent: Mutt/1.4.2.3i Cc: freebsd-fs@freebsd.org Subject: Re: UFS label limitations X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: rick-freebsd2008@kiwi-computer.com List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Dec 2008 20:10:48 -0000 On Tue, Dec 16, 2008 at 02:29:52PM +0100, Dag-Erling Smørgrav wrote: > "Rick C. Petty" writes: > > Dag-Erling Smørgrav writes: > > > Stick to the POSIX portable file name character set: [A-Za-z0-9._-] > > Good idea. It gives me the separators I need. Would a committer be > > willing to review and commit the attached (inline) patch? > > Take a look at strspn(3). You think it's better to use strspn than a couple range checks? I would have thought the character lookup with strspn would be slower and more ghastly to look at. -- Rick C. Petty