From owner-freebsd-current@FreeBSD.ORG  Wed Aug  3 14:32:51 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B34E9106566B;
	Wed,  3 Aug 2011 14:32:51 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com
	[209.85.213.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 388558FC0C;
	Wed,  3 Aug 2011 14:32:50 +0000 (UTC)
Received: by ywm39 with SMTP id 39so607621ywm.13
	for <multiple recipients>; Wed, 03 Aug 2011 07:32:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	bh=ivXN+R69T7RkXvzQ0YA1IiHrAPTcW2ZVralhfl63xAs=;
	b=ekU1vJaW7tpSz7mWPfQKxr5nL0Bn8GwmJlNrGo2hEEJ34rfimEBhxxjlcYVpJj1ayN
	2bWobwogqtsSuGCjeYF7XNqjRh6LqEUSR0dMQnBSXqjmPHbwbGG4DIgVsiI1dKTBbcwz
	hVzcaIx/h1sIKghbK/pCCLf+GOtP+FIcxPceU=
MIME-Version: 1.0
Received: by 10.236.175.35 with SMTP id y23mr6578455yhl.495.1312381970428;
	Wed, 03 Aug 2011 07:32:50 -0700 (PDT)
Sender: asmrookie@gmail.com
Received: by 10.236.109.13 with HTTP; Wed, 3 Aug 2011 07:32:50 -0700 (PDT)
In-Reply-To: <8639ib1968.fsf@gmail.com>
References: <8639ib1968.fsf@gmail.com>
Date: Wed, 3 Aug 2011 10:32:50 -0400
X-Google-Sender-Auth: 6CcNSPADgwanz-tosPaamj8h7uY
Message-ID: <CAJ-FndCLs59UCUtNBjFeanxQFkqGZVoWRnAS0GdXQ7d9-P-C7Q@mail.gmail.com>
From: Attilio Rao <attilio@freebsd.org>
To: Pan Tsu <inyaoo@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: George Neville-Neil <gnn@neville-neil.com>, freebsd-current@freebsd.org,
	Sergey Kandaurov <pluknet@freebsd.org>,
	Fabien Thomas <fabient@freebsd.org>, Andriy Gapon <avg@freebsd.org>
Subject: Re: pmcstat(8) and machdep.hlt_cpus
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Aug 2011 14:32:51 -0000

2011/7/12 Pan Tsu <inyaoo@gmail.com>:
> pmcstat(8) stopped to work for me after largeSMP landed in r222813.
> At the time only pmccontrol(8) was updated. Then the next day
> machdep.hlt_cpus was ripped out. So, I've assumed it's going to
> be fixed by subsequent commits and commented out related code locally.
>
> =C2=A0$ qemu -smp 2 -nographic ...
> =C2=A0$ kldload hwpmc
> =C2=A0$ pmcstat -S instructions -T
> =C2=A0pmcstat: ERROR: Cannot determine which CPUs are halted: No such fil=
e or directory
> =C2=A0Exit 71

Hey Pan,
do you think you can try the following patch?:
http://www.freebsd.org/~attilio/pmcstat_cpumask.diff

This should fix pmcstat for correctly using cpuset_t rather than
custom 32 bit integers.

Thanks,
Attilio


--=20
Peace can only be achieved by understanding - A. Einstein