Date: Tue, 11 Dec 2001 09:00:03 -0800 (PST) From: Peter Pentchev <roam@ringlet.net> To: freebsd-bugs@FreeBSD.org Subject: Re: misc/32687: scripts in /usr/local/etc/rc.d not executed in 4.4-STABLE Message-ID: <200112111700.fBBH03P71843@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR misc/32687; it has been noted by GNATS.
From: Peter Pentchev <roam@ringlet.net>
To: Sheldon Hearn <sheldonh@starjuice.net>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: misc/32687: scripts in /usr/local/etc/rc.d not executed in 4.4-STABLE
Date: Tue, 11 Dec 2001 18:51:49 +0200
On Tue, Dec 11, 2001 at 08:30:01AM -0800, Sheldon Hearn wrote:
> The following reply was made to PR misc/32687; it has been noted by GNATS.
>
> On Tue, 11 Dec 2001 08:20:01 PST, Peter Pentchev wrote:
>
> > Ahhh.. just looking at the line now. I get what the problem is. since
> > script_name_sep is undefined, slist is going to be equal to something like
> > "apache.shmysql.shdhcpd.sh" and thus isn't going to exceute them because
> > obviously such a file does not exist.
>
> Peter, do you think it's worth building a default value for script_name_sep
> into rc itself so this doesn't bite folks in the 4.5-RELEASE upgrade?
>
> I accept that you'd have to try hard to be bitten, but this little bit
> of ugliness may save us a few PRs?
This makes sense. How about the attached patch?
The warning message clutters the output, though; it almost certainly
overflows to the next line on the screen, not to mention overflowing
the 80-character source line.. I am thinking of shortening it somehow,
maybe you or somebody else could suggest another wording?
G'luck,
Peter
--
I am the meaning of this sentence.
Index: src/etc/rc
===================================================================
RCS file: /home/ncvs/src/etc/rc,v
retrieving revision 1.287
diff -u -r1.287 rc
--- src/etc/rc 11 Dec 2001 08:21:45 -0000 1.287
+++ src/etc/rc 11 Dec 2001 16:43:24 -0000
@@ -813,6 +813,10 @@
*)
echo -n 'Local package initialization:'
slist=""
+ if [ -z "${script_name_sep}" ]; then
+ echo -n ' Empty script_name_sep, setting a default value of " "..'
+ script_name_sep=" "
+ fi
for dir in ${local_startup}; do
if [ -d "${dir}" ]; then
for script in ${dir}/*.sh; do
Index: src/etc/rc.shutdown
===================================================================
RCS file: /home/ncvs/src/etc/rc.shutdown,v
retrieving revision 1.20
diff -u -r1.20 rc.shutdown
--- src/etc/rc.shutdown 24 Nov 2001 16:12:03 -0000 1.20
+++ src/etc/rc.shutdown 11 Dec 2001 16:42:36 -0000
@@ -103,6 +103,10 @@
;;
*)
slist=""
+ if [ -z "${script_name_sep}" ]; then
+ echo -n ' Empty script_name_sep, setting a default value of " "..'
+ script_name_sep=" "
+ fi
for dir in ${local_startup}; do
if [ -d "${dir}" ]; then
for script in ${dir}/*.sh; do
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200112111700.fBBH03P71843>