From owner-freebsd-bugs@FreeBSD.ORG  Sun Feb 13 22:00:20 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F2C3910656B1
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 13 Feb 2011 22:00:20 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 470678FC35
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 13 Feb 2011 22:00:19 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p1DM0J4O085541
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 13 Feb 2011 22:00:19 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p1DM0JOL085521;
	Sun, 13 Feb 2011 22:00:19 GMT (envelope-from gnats)
Resent-Date: Sun, 13 Feb 2011 22:00:19 GMT
Resent-Message-Id: <201102132200.p1DM0JOL085521@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Antoine Martin <antoine@nagafix.co.uk>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 70FCE106564A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun, 13 Feb 2011 21:50:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 5F86A8FC16
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun, 13 Feb 2011 21:50:07 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p1DLo6E0056154
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Feb 2011 21:50:06 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p1DLo6O9056153;
	Sun, 13 Feb 2011 21:50:06 GMT (envelope-from nobody)
Message-Id: <201102132150.p1DLo6O9056153@red.freebsd.org>
Date: Sun, 13 Feb 2011 21:50:06 GMT
From: Antoine Martin <antoine@nagafix.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/154755: existing pygtk patch needs to be applied
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Feb 2011 22:00:21 -0000


>Number:         154755
>Category:       misc
>Synopsis:       existing pygtk patch needs to be applied
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 13 22:00:18 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Antoine Martin
>Release:        8.1
>Organization:
devloop
>Environment:
>Description:
See this upstream bug (includes the patch):

https://bugzilla.gnome.org/show_bug.cgi?id=640738
>How-To-Repeat:
import signal
import gtk

signal.signal(signal.SIGCHLD, lambda *args: None)
gtk.main()

Run it, send it SIGCHLD.  CPU usage goes to 100%.
>Fix:
diff --git a/gtk/gtk.override b/gtk/gtk.override
index 75018f4..7261d9c 100644
--- a/gtk/gtk.override
+++ b/gtk/gtk.override
@@ -1152,8 +1152,9 @@ pygtk_main_watch_check(GSource *source)
     PySignalWatchSource *real_source = (PySignalWatchSource *)source;
     GPollFD *poll_fd = &real_source->fd;
     int data_size = 0;
+    char dummy;
     if (poll_fd->revents & G_IO_IN)
-        data_size = read(poll_fd->fd, 0, 1);
+        data_size = read(poll_fd->fd, &dummy, 1);
 #endif
 
     state = pyg_gil_state_ensure();

>Release-Note:
>Audit-Trail:
>Unformatted: